linux-kernel - RE: [PATCH rtw-next] wifi: rtw89: Replace hardcoded strings with helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <715313b943d84cfeb3a337dc20be5f6a@realtek.com>
Date: Mon, 22 Sep 2025 05:50:50 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Yu-Chun Lin <eleanor15x@...il.com>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        CY_Huang[黃鉦晏] <cy.huang@...ltek.com>,
        Stanley Chang[昌育德] <stanley_chang@...ltek.com>,
        "jserv@...s.ncku.edu.tw" <jserv@...s.ncku.edu.tw>,
        "visitorckw@...il.com"
	<visitorckw@...il.com>
Subject: RE: [PATCH rtw-next] wifi: rtw89: Replace hardcoded strings with helper functions

Yu-Chun Lin <eleanor15x@...il.com> wrote:
> Replace hardcoded strings with 'str_on_off()', 'str_enable_disable()',
> and 'str_read_write()'.
> 
> The change improves readability and enables potential string deduplication
> by the linker, which may slightly reduce binary size.

Have you measured the change of binary size? Maybe you can share the result
here.

> 
> Signed-off-by: Yu-Chun Lin <eleanor15x@...il.com>
> ---
>  drivers/net/wireless/realtek/rtw89/rtw8851b_rfk.c | 10 ++++++----
>  drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c | 10 ++++++----
>  drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c |  8 +++++---
>  drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c | 11 ++++++-----
>  drivers/net/wireless/realtek/rtw89/usb.c          |  3 ++-
>  drivers/net/wireless/realtek/rtw89/wow.c          |  5 ++++-
>  6 files changed, 29 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8851b_rfk.c
> b/drivers/net/wireless/realtek/rtw89/rtw8851b_rfk.c
> index 84c46d2f4d85..000753061e38 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8851b_rfk.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8851b_rfk.c
> @@ -2,6 +2,8 @@
>  /* Copyright(c) 2022-2023  Realtek Corporation
>   */
> 
> +#include <linux/string_choices.h>
> +

Driver has included this implicitly, so don't need to include it across
whole patch.

Otherwise looks good to me.