linux-kernel - Re: [PATCH] xen: take system_transition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8d1d076-81b0-424e-b281-dfbd49130d38@suse.com>
Date: Mon, 22 Sep 2025 08:06:26 +0200
From: Jürgen Groß <jgross@...e.com>
To: Marek Marczykowski-Górecki
 <marmarek@...isiblethingslab.com>, linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org, Stefano Stabellini <sstabellini@...nel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>,
 "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
 Mario Limonciello <mario.limonciello@....com>,
 "moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH] xen: take system_transition_mutex on suspend

On 21.09.25 18:28, Marek Marczykowski-Górecki wrote:
> Xen's do_suspend() calls dpm_suspend_start() without taking required
> system_transition_mutex. Since 12ffc3b1513eb moved the
> pm_restrict_gfp_mask() call, not taking that mutex results in a WARN.
> 
> Take the mutex in do_suspend(), and use mutex_trylock() to follow
> how enter_state() does this.
> 
> Suggested-by: Jürgen Groß <jgross@...e.com>
> Fixes: 12ffc3b1513eb "PM: Restrict swap use to later in the suspend sequence"
> Link: https://lore.kernel.org/xen-devel/aKiBJeqsYx_4Top5@mail-itl/
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@...isiblethingslab.com>
> Cc: stable@...r.kernel.org # v6.16+

Reviewed-by: Juergen Gross <jgross@...e.com>

Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3684 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)