linux-kernel - Re: [PATCH v2] cleanup: Fix "unused function" warnings with conditional guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNDtuF13zW8R_fkx@smile.fi.intel.com>
Date: Mon, 22 Sep 2025 09:33:28 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: dan.j.williams@...el.com
Cc: Andrew Morton <akpm@...ux-foundation.org>, peterz@...radead.org,
	linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dave Jiang <dave.jiang@...el.com>,
	David Lechner <dlechner@...libre.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>
Subject: Re: [PATCH v2] cleanup: Fix "unused function" warnings with
 conditional guards

On Thu, Sep 18, 2025 at 12:26:28PM -0700, dan.j.williams@...el.com wrote:
> Andy Shevchenko wrote:
> > On Wed, Sep 17, 2025 at 04:21:07PM -0700, dan.j.williams@...el.com wrote:
> > > Andrew Morton wrote:

[..]

> > > > > Alternatively just merge the suggestion in [1], and call it a day.
> > > > > 
> > > > > Link: http://lore.kernel.org/20250813152142.GP4067720@noisy.programming.kicks-ass.net [1]
> > > > 
> > > > lgtm, unless we think this (your) patch improves the code for other reasons?
> > > 
> > > The tl;dr above is that the warning could have small value, but probably
> > > not greater than the overall benefit to Linux to stop bothering folks
> > > with this low-value warning by default at W=1.
> > > 
> > > So I am over the sunk costs, and moving this warning to W=2 is the way
> > > to go.
> > 
> > Can somebody add a fix so, we have v6.17 able to be built with `make W=1`, please?
> 
> Andy, might you have time to take Peter's proposed diff and wrap it with
> a changelog for Andrew to pull?

I will try my best, thanks!


-- 
With Best Regards,
Andy Shevchenko