linux-kernel - Re: [PATCH 1/7] md: factor error handling out of md_done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9da425ac-1a9b-29f8-f390-7aea0033a08c@huaweicloud.com>
Date: Mon, 22 Sep 2025 09:24:29 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: linan666@...weicloud.com, song@...nel.org, neil@...wn.name,
 namhyung@...il.com
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
 yangerkun@...wei.com, yi.zhang@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH 1/7] md: factor error handling out of md_done_sync into
 helper

在 2025/09/17 17:35, linan666@...weicloud.com 写道:
> From: Li Nan<linan122@...wei.com>
> 
> The 'ok' parameter in md_done_sync() is redundant for most callers that
> always pass 'true'. Factor error handling logic into a separate helper
> function md_sync_error() to eliminate unnecessary parameter passing and
> improve code clarity.
> 
> No functional changes introduced.
> 
> Signed-off-by: Li Nan<linan122@...wei.com>
> ---
>   drivers/md/md.h     |  3 ++-
>   drivers/md/md.c     | 17 ++++++++++-------
>   drivers/md/raid1.c  | 17 ++++++++---------
>   drivers/md/raid10.c | 11 ++++++-----
>   drivers/md/raid5.c  | 14 ++++++++------
>   5 files changed, 34 insertions(+), 28 deletions(-)

LGTM
Reviewed-by: Yu Kuai <yukuai3@...wei.com>