linux-kernel - [PATCH 12/15 6.6.y] minmax.h: use BUILD_BUG_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250922103241.16213-13-farbere@amazon.com>
Date: Mon, 22 Sep 2025 10:32:38 +0000
From: Eliav Farber <farbere@...zon.com>
To: <richard@....at>, <anton.ivanov@...bridgegreys.com>,
	<johannes@...solutions.net>, <dave.hansen@...ux.intel.com>,
	<luto@...nel.org>, <peterz@...radead.org>, <tglx@...utronix.de>,
	<mingo@...hat.com>, <bp@...en8.de>, <x86@...nel.org>, <hpa@...or.com>,
	<tony.luck@...el.com>, <qiuxu.zhuo@...el.com>, <james.morse@....com>,
	<mchehab@...nel.org>, <rric@...nel.org>, <harry.wentland@....com>,
	<sunpeng.li@....com>, <Rodrigo.Siqueira@....com>,
	<alexander.deucher@....com>, <christian.koenig@....com>,
	<Xinhui.Pan@....com>, <airlied@...il.com>, <daniel@...ll.ch>,
	<evan.quan@....com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>, <jdelvare@...e.com>,
	<linux@...ck-us.net>, <linus.walleij@...aro.org>,
	<dmitry.torokhov@...il.com>, <wens@...e.org>, <jernej.skrabec@...il.com>,
	<samuel@...lland.org>, <agk@...hat.com>, <snitzer@...nel.org>,
	<dm-devel@...ts.linux.dev>, <mailhol.vincent@...adoo.fr>,
	<wg@...ndegger.com>, <mkl@...gutronix.de>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<alexandre.torgue@...s.st.com>, <joabreu@...opsys.com>,
	<mcoquelin.stm32@...il.com>, <krzysztof.kozlowski@...aro.org>,
	<malattia@...ux.it>, <hdegoede@...hat.com>, <ilpo.jarvinen@...ux.intel.com>,
	<markgross@...nel.org>, <artur.paszkiewicz@...el.com>, <jejb@...ux.ibm.com>,
	<martin.petersen@...cle.com>, <sakari.ailus@...ux.intel.com>,
	<gregkh@...uxfoundation.org>, <clm@...com>, <josef@...icpanda.com>,
	<dsterba@...e.com>, <luc.vanoostenryck@...il.com>, <rostedt@...dmis.org>,
	<mhiramat@...nel.org>, <pmladek@...e.com>,
	<andriy.shevchenko@...ux.intel.com>, <linux@...musvillemoes.dk>,
	<senozhatsky@...omium.org>, <minchan@...nel.org>,
	<akpm@...ux-foundation.org>, <dsahern@...nel.org>, <shuah@...nel.org>,
	<keescook@...omium.org>, <wad@...omium.org>, <farbere@...zon.com>,
	<David.Laight@...LAB.COM>, <arnd@...nel.org>, <linux-um@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>,
	<amd-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-hwmon@...r.kernel.org>, <linux-input@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-sunxi@...ts.linux.dev>,
	<linux-media@...r.kernel.org>, <linux-can@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
	<platform-driver-x86@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<linux-staging@...ts.linux.dev>, <linux-btrfs@...r.kernel.org>,
	<linux-sparse@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
	<linux-mm@...ck.org>, <linux-kselftest@...r.kernel.org>,
	<bpf@...r.kernel.org>, <stable@...r.kernel.org>
CC: Christoph Hellwig <hch@...radead.org>, Dan Carpenter
	<dan.carpenter@...aro.org>, "Jason A. Donenfeld" <Jason@...c4.com>, "Jens
 Axboe" <axboe@...nel.dk>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Mateusz Guzik <mjguzik@...il.com>, Matthew Wilcox <willy@...radead.org>,
	Pedro Falcato <pedro.falcato@...il.com>
Subject: [PATCH 12/15 6.6.y] minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()

From: David Laight <David.Laight@...LAB.COM>

[ Upstream commit a5743f32baec4728711bbc01d6ac2b33d4c67040 ]

Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity check
of the bounds in clamp().  Gives better error coverage and one less
expansion of the arguments.

Link: https://lkml.kernel.org/r/34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com
Signed-off-by: David Laight <david.laight@...lab.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Arnd Bergmann <arnd@...nel.org>
Cc: Christoph Hellwig <hch@...radead.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Jason A. Donenfeld <Jason@...c4.com>
Cc: Jens Axboe <axboe@...nel.dk>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Mateusz Guzik <mjguzik@...il.com>
Cc: Matthew Wilcox <willy@...radead.org>
Cc: Pedro Falcato <pedro.falcato@...il.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Eliav Farber <farbere@...zon.com>
---
 include/linux/minmax.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/minmax.h b/include/linux/minmax.h
index 6f7ea669d305..91aa1b90c1bb 100644
--- a/include/linux/minmax.h
+++ b/include/linux/minmax.h
@@ -106,8 +106,7 @@
 	__auto_type uval = (val);						\
 	__auto_type ulo = (lo);							\
 	__auto_type uhi = (hi);							\
-	static_assert(__builtin_choose_expr(__is_constexpr((lo) > (hi)), 	\
-			(lo) <= (hi), true),					\
+	BUILD_BUG_ON_MSG(statically_true(ulo > uhi),				\
 		"clamp() low limit " #lo " greater than high limit " #hi);	\
 	BUILD_BUG_ON_MSG(!__types_ok3(uval, ulo, uhi),				\
 		"clamp("#val", "#lo", "#hi") signedness error");		\
-- 
2.47.3