linux-kernel - Re: [PATCH 5/7 6.12.y] minmax.h: move all the clamp() definitions after the min/max() ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025092204-reoccupy-fax-6b7a@gregkh>
Date: Mon, 22 Sep 2025 14:14:19 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eliav Farber <farbere@...zon.com>
Cc: akpm@...ux-foundation.org, David.Laight@...lab.com, arnd@...nel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Christoph Hellwig <hch@...radead.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	"Jason A. Donenfeld" <Jason@...c4.com>,
	Jens Axboe <axboe@...nel.dk>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Mateusz Guzik <mjguzik@...il.com>,
	Matthew Wilcox <willy@...radead.org>,
	Pedro Falcato <pedro.falcato@...il.com>
Subject: Re: [PATCH 5/7 6.12.y] minmax.h: move all the clamp() definitions
 after the min/max() ones

On Mon, Sep 22, 2025 at 10:31:21AM +0000, Eliav Farber wrote:
> From: David Laight <David.Laight@...LAB.COM>
> 
> [ Upstream commit c3939872ee4a6b8bdcd0e813c66823b31e6e26f7 ]
> 
> At some point the definitions for clamp() got added in the middle of the
> ones for min() and max().  Re-order the definitions so they are more
> sensibly grouped.
> 
> Link: https://lkml.kernel.org/r/8bb285818e4846469121c8abc3dfb6e2@AcuMS.aculab.com
> Signed-off-by: David Laight <david.laight@...lab.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Arnd Bergmann <arnd@...nel.org>
> Cc: Christoph Hellwig <hch@...radead.org>
> Cc: Dan Carpenter <dan.carpenter@...aro.org>
> Cc: Jason A. Donenfeld <Jason@...c4.com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> Cc: Mateusz Guzik <mjguzik@...il.com>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Pedro Falcato <pedro.falcato@...il.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Eliav Farber <farbere@...zon.com>
> ---
>  include/linux/minmax.h | 109 +++++++++++++++++++----------------------
>  1 file changed, 51 insertions(+), 58 deletions(-)

This diff looks odd.  The upstream commit diffstat is:

include/linux/minmax.h |  131 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------
1 file changed, 62 insertions(+), 69 deletions(-)

which does not match this diffstat, nor the diff itself.

But, if I backport the original commit myself, it matches up exactly
with what you show here, which is odd.

diff is "fun", ugh...

Anyway, not a complaint, just something that others might note if they
are comparing diffs here like I do.

thanks,

greg k-h