linux-kernel - RE: [EXT] Re: [PATCH v2 3/5] media: nxp: imx8-isi: Add parallel camera input support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB9080EE291FED39F13086C473FA12A@AS8PR04MB9080.eurprd04.prod.outlook.com>
Date: Mon, 22 Sep 2025 02:16:39 +0000
From: "G.N. Zhou" <guoniu.zhou@....com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, Frank Li <frank.li@....com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Alice Yuan <alice.yuan@....com>
Subject: RE: [EXT] Re: [PATCH v2 3/5] media: nxp: imx8-isi: Add parallel
 camera input support

Hi Laurent,

Thanks for your review.

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Sent: Monday, September 22, 2025 6:19 AM
> To: G.N. Zhou <guoniu.zhou@....com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Shawn Guo <shawnguo@...nel.org>; Sascha Hauer
> <s.hauer@...gutronix.de>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>; Frank Li
> <frank.li@....com>; linux-media@...r.kernel.org; devicetree@...r.kernel.org;
> imx@...ts.linux.dev; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; Alice Yuan <alice.yuan@....com>
> Subject: [EXT] Re: [PATCH v2 3/5] media: nxp: imx8-isi: Add parallel camera
> input support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
> 
> 
> Hi Guoniu,
> 
> Thank you for the patch.
> 
> The subject line should mention the i.MX93:
> 
> media: nxp: imx8-isi: Add parallel camera input support for i.MX93

Okay.

> 
> On Fri, Sep 05, 2025 at 02:56:00PM +0800, Guoniu Zhou wrote:
> > From: Alice Yuan <alice.yuan@....com>
> >
> > The ISI module on i.MX93 implements one camera input which can be
> > connected to either of MIPI CSI-2 or parallel camera. The source type
> > can be selected by setting camera mux control register.
> >
> > Signed-off-by: Alice Yuan <alice.yuan@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > Signed-off-by: Guoniu Zhou <guoniu.zhou@....com>
> > ---
> >  drivers/media/platform/nxp/imx8-isi/imx8-isi-gasket.c | 11
> > +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-gasket.c
> > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-gasket.c
> > index
> >
> 2f5e7299b537d612fb1fe6688c1b75bfd2d6049b..42b2ed2bbdf7259bc83d0678
> 2563
> > 43a3b606568a 100644
> > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-gasket.c
> > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-gasket.c
> > @@ -61,6 +61,7 @@ const struct mxc_gasket_ops mxc_imx8_gasket_ops = {
> >  #define DISP_MIX_CAMERA_MUX                     0x30
> >  #define DISP_MIX_CAMERA_MUX_DATA_TYPE(x)
> FIELD_PREP(GENMASK(8, 3), (x))
> >  #define DISP_MIX_CAMERA_MUX_GASKET_ENABLE       BIT(16)
> > +#define DISP_MIX_CAMERA_MUX_GASKET_SRC          BIT(17)
> 
> Let's spell this out fully to match the reference manual:
> 
> #define DISP_MIX_CAMERA_MUX_GASKET_SOURCE_TYPE  BIT(17)
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> >  static void mxc_imx93_gasket_enable(struct mxc_isi_dev *isi,
> >                                   const struct v4l2_mbus_frame_desc
> > *fd, @@ -71,6 +72,16 @@ static void mxc_imx93_gasket_enable(struct
> > mxc_isi_dev *isi,
> >
> >       val = DISP_MIX_CAMERA_MUX_DATA_TYPE(fd->entry[0].bus.csi2.dt);
> >       val |= DISP_MIX_CAMERA_MUX_GASKET_ENABLE;
> > +
> > +     /*
> > +      * CAMERA MUX
> > +      * - [17]:      Selects source input to gasket
> > +      *              0: Data from MIPI CSI
> > +      *              1: Data from parallel camera
> > +      */
> > +     if (fd->type == V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL)
> > +             val |= DISP_MIX_CAMERA_MUX_GASKET_SRC;
> > +
> >       regmap_write(isi->gasket, DISP_MIX_CAMERA_MUX, val);  }
> >
> 
> --
> Regards,
> 
> Laurent Pinchart