linux-kernel - Re: [PATCH v4 1/2] pinctrl: renesas: rzg2l: Fix PMC restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVCMPkh+D9G1rNJmhnyqOV3Ya5jb_VKjZEdVjysEqFVUw@mail.gmail.com>
Date: Mon, 22 Sep 2025 15:13:11 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.au@...il.com>
Subject: Re: [PATCH v4 1/2] pinctrl: renesas: rzg2l: Fix PMC restore

Hi Biju,

Thanks for your patch!

On Sun, 21 Sept 2025 at 13:16, Biju Das <biju.das.jz@...renesas.com> wrote:
> The PMC restore needs unlocking the register using PWPR register.
>
> Fixes: 14c32dc1f63d ("pinctrl: renesas: rzg2l: Add function pointer for PFC register locking")

I would rather say:

    Fixes: ede014cd1ea6422d ("pinctrl: renesas: rzg2l: Add function
pointer for PMC register write")

as that is the (later) commit that should have converted the direct
write to an indirect call.  However, both commits prepare for the
advent of RZ/V2H support, and the actual issue cannot be experienced
before commit 9bd95ac86e700ab8 ("pinctrl: renesas: rzg2l: Add support
for RZ/V2H SoC").

> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-pinctrl for v6.19.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds