linux-kernel - Re: [PATCH v2] ARM: dts: microchip: sama7d65: Add GPIO buttons and LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d06e5323-995e-425e-8ace-c04e9140f5d0@microchip.com>
Date: Mon, 22 Sep 2025 15:28:40 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: <Ryan.Wanner@...rochip.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <alexandre.belloni@...tlin.com>,
	<claudiu.beznea@...on.dev>
CC: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-leds@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: microchip: sama7d65: Add GPIO buttons and
 LEDs

On 17/09/2025 at 23:04, Ryan.Wanner@...rochip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@...rochip.com>
> 
> Add the USER button as a GPIO input as well as add the LEDs and enable
> the blue LED as a heartbeat.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
And queued in at91-dt branch.

Regards,
   Nicolas

> ---
> Changes v1 -> v2:
> - Remove the label node in the LEDs.
> - Use properties color and function to describe the LEDs.
> - Add phandles for the LEDs.
> 
>   .../dts/microchip/at91-sama7d65_curiosity.dts | 51 +++++++++++++++++++
>   1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
> index f091cc40a9f0..927c27260b6c 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
> @@ -11,6 +11,8 @@
>   #include "sama7d65-pinfunc.h"
>   #include "sama7d65.dtsi"
>   #include <dt-bindings/mfd/atmel-flexcom.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
>   #include <dt-bindings/pinctrl/at91.h>
>   
>   / {
> @@ -26,6 +28,43 @@ chosen {
>   		stdout-path = "serial0:115200n8";
>   	};
>   
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_key_gpio_default>;
> +
> +		button {
> +			label = "PB_USER";
> +			gpios = <&pioa PIN_PC10 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_PROG1>;
> +			wakeup-source;
> +		};
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_led_gpio_default>;
> +
> +		led0: led-red {
> +			color = <LED_COLOR_ID_RED>;
> +			gpios = <&pioa PIN_PB17 GPIO_ACTIVE_HIGH>; /* Conflict with pwm. */
> +		};
> +
> +		led1: led-green {
> +			color = <LED_COLOR_ID_GREEN>;
> +			gpios = <&pioa PIN_PB15 GPIO_ACTIVE_HIGH>; /* Conflict with pwm. */
> +		};
> +
> +		led2: led-blue {
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_HEARTBEAT;
> +			gpios = <&pioa PIN_PA21 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
> +
>   	memory@...00000 {
>   		device_type = "memory";
>   		reg = <0x60000000 0x40000000>;
> @@ -352,6 +391,18 @@ pinctrl_i2c10_default: i2c10-default {
>   		bias-pull-up;
>   	};
>   
> +	pinctrl_key_gpio_default: key-gpio-default {
> +		pinmux = <PIN_PC10__GPIO>;
> +		bias-pull-up;
> +	};
> +
> +	pinctrl_led_gpio_default: led-gpio-default {
> +		pinmux = <PIN_PB15__GPIO>,
> +			 <PIN_PB17__GPIO>,
> +			 <PIN_PA21__GPIO>;
> +		bias-pull-up;
> +	};
> +
>   	pinctrl_sdmmc1_default: sdmmc1-default {
>   		cmd-data {
>   			pinmux = <PIN_PB22__SDMMC1_CMD>,