linux-kernel - Re: [PATCH v4 0/4] Add Aspeed AST2700 uhci support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67259dbb-4586-4099-9762-5c1d143db7db@rowland.harvard.edu>
Date: Mon, 22 Sep 2025 09:58:15 -0400
From: Alan Stern <stern@...land.harvard.edu>
To: Ryan Chen <ryan_chen@...eedtech.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/4] Add Aspeed AST2700 uhci support

On Mon, Sep 22, 2025 at 01:20:41PM +0800, Ryan Chen wrote:
> This patch series adds support for the UHCI controller found on the
> Aspeed AST2700 SoC.
> 
> Compared to earlier SoCs (AST2400/2500/2600), AST2700 UHCI:
>  - requires a reset line to be deasserted before use
>  - supports 64-bit DMA addressing
> 
> This series updates the bindings and platform driver accordingly.

For patches 2/4 and 4/4:

Reviewed-by: Alan Stern <stern@...land.harvard.edu>

Alan Stern

> v4:
> - usb-uhci.yaml
>  - fix errors 'make dt_binding_check'
> - uhci-platform.c
>  - remove IS_ERR_OR_NULL(uhci->rsts) check, due to reset_control_assert
>    will return 0, when uhci->rsts is null.
>  - use dma_mask_32 as default, and just add aspeed,ast2700-uhci for dma_64.
> 
> v3:
> - uhci-platform.c
>  - add reset_control_assert in uhci_hcd_platform_remove.
> 
> v2:
> - usb-uhci.yaml
>  - add required resets for aspeed,ast2700-uhci
> - uhci-platform.c
>  - change the err_clk before err_reset.
> 
> Ryan Chen (4):
>   dt-bindings: usb: uhci: Add reset property
>   usb: uhci: Add reset control support
>   dt-bindings: usb: uhci: Add Aspeed AST2700 compatible
>   usb: uhci: Add Aspeed AST2700 support
> 
>  .../devicetree/bindings/usb/usb-uhci.yaml     | 13 ++++++++
>  drivers/usb/host/uhci-hcd.h                   |  1 +
>  drivers/usb/host/uhci-platform.c              | 31 ++++++++++++++++---
>  3 files changed, 41 insertions(+), 4 deletions(-)
> 
> -- 
> 2.34.1
>