linux-kernel - Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd660ce0388afb61e476f164335600f3fc2b1fb6.camel@codeconstruct.com.au>
Date: Mon, 22 Sep 2025 12:10:19 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Rebecca Cran <rebecca@...io.com>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC

Hi Rebecca,

On Wed, 2025-09-17 at 12:04 -0600, Rebecca Cran wrote:
> The ASRock Rack ALTRAD8 BMC is an Aspeed AST2500-based BMC for the
> ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards with an Ampere Altra
> processor. The BMC runs OpenBMC.
> 
> These patches add a device tree and binding for the BMC.
> 
> **Changes between v1 and v2**
> 
> - Reordered nodes to be in alphabetical order.
> - Removed status lines.
> - Fixed naming.
> 
> There are still several warnings from
> make CHECK_DTBS=y ARCH=arm W=1 aspeed/aspeed-bmc-asrock-altrad8.dtb

Thanks for checking!

> I believe the only one which is reporting an issue in my dts file (as opposed
> to included files) is the first, and that's because the code partition contains
> the TF-A and UEFI areas. I couldn't see a way to suppress it.
> 
> aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi@...30000/flash@...artitions/code@...000: duplicate unit-address (also used in node /ahb/spi@...30000/flash@...artitions/tfa@...000)

It seems odd that the partitions intersect. Are the offsets correct? If
they are, can you add comments to the DTS discussing what's going on
there?

> aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/memory-controller@...e0000: failed to match any schema with compatible: ['aspeed,ast2500-sdram-edac']

*snip*

> aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
> 	from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#

This one needs fixing.

Cheers,

Andrew