linux-kernel - Re: [PATCH v3 07/36] powerpc/vdso: Explicitly include asm/cputable.h and asm/feature-fixups.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1348fmcjh.fsf@mpe.ellerman.id.au>
Date: Mon, 22 Sep 2025 12:44:18 +1000
From: Michael Ellerman <mpe@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>, Thomas Weißschuh
 <thomas.weissschuh@...utronix.de>, Andy Lutomirski <luto@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>, Vincenzo Frascino
 <vincenzo.frascino@....com>, Arnd Bergmann <arnd@...db.de>, "David S.
 Miller" <davem@...emloft.net>, Andreas Larsson <andreas@...sler.com>, Nick
 Alcock <nick.alcock@...cle.com>, John Stultz <jstultz@...gle.com>, Stephen
 Boyd <sboyd@...nel.org>, John Paul Adrian Glaubitz
 <glaubitz@...sik.fu-berlin.de>, Shuah Khan <shuah@...nel.org>, Catalin
 Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Theodore
 Ts'o <tytso@....edu>, "Jason A. Donenfeld" <Jason@...c4.com>, Russell King
 <linux@...linux.org.uk>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Nicholas Piggin <npiggin@...il.com>, Huacai Chen <chenhuacai@...nel.org>,
 WANG Xuerui <kernel@...0n.name>, Thomas Bogendoerfer
 <tsbogend@...ha.franken.de>, Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle
 <svens@...ux.ibm.com>, Nagarathnam Muthusamy
 <nagarathnam.muthusamy@...cle.com>, Shannon Nelson <sln@...main.com>,
 Nicholas Piggin <npiggin@...il.com>
Cc: linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org, loongarch@...ts.linux.dev,
 linux-mips@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH v3 07/36] powerpc/vdso: Explicitly include
 asm/cputable.h and asm/feature-fixups.h

Christophe Leroy <christophe.leroy@...roup.eu> writes:
> Le 17/09/2025 à 16:00, Thomas Weißschuh a écrit :
>> The usage of ASM_FTR_IFCLR(CPU_TR_ARCH_31) requires asm/cputable.h and
>> asm/feature-fixups.h. Currently these headers are included transitively,
>> but that transitive inclusion is about to go away.
>
> Hum ...
>
> That was unexpectedly added by commit 9c7bfc2dc21e ("powerpc/64s: Make 
> POWER10 and later use pause_short in cpu_relax loops")
>
> In theory, vdso/ headers shouldn't include any headers outside of vdso/

Oops, looks like that was my fault.

It's expected that there can be feature fixups needed in the VDSO,
vdso_feature_fixups() handles them, so that's OK. But the headers
pulling from outside vdso is a pity.

Still this patch is fine as-is.

cheers