linux-kernel - Re: [PATCH] drm/amd/amdgpu: use kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_PnEJYpw2Zu9hPVoKk24YBmZfcSNst=Enqd899eLvpWOg@mail.gmail.com>
Date: Tue, 23 Sep 2025 09:47:30 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Moktar SELLAMI <smokthar925@...il.com>
Cc: alexander.deucher@....com, christian.koenig@....com, airlied@...il.com, 
	simona@...ll.ch, Hawking.Zhang@....com, tao.zhou1@....com, lijo.lazar@....com, 
	ganglxie@....com, victor.skvortsov@....com, candice.li@....com, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linuxfoundation.org, 
	skhan@...uxfoundation.org, david.hunter.linux@...il.com
Subject: Re: [PATCH] drm/amd/amdgpu: use kmalloc_array instead of kmalloc

On Mon, Sep 22, 2025 at 4:14 PM Moktar SELLAMI <smokthar925@...il.com> wrote:
>
> Replace kmalloc -> kmalloc_array in drm/amd/amdgpu/amdgpu_ras.c .
>
> As per said in the Documentation/process/deprecated.rst, dynamic size
> calculation should not be performed in memory allocator function
> arguments due to the risk of overflow.
>
> Signed-off-by: Moktar SELLAMI <smokthar925@...il.com>

Thanks for the patch.  Some already supplied a similar patch which was applied.

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 540817e296da..8dbb9e349a8e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -2566,7 +2566,7 @@ static int amdgpu_ras_badpages_read(struct amdgpu_device *adev,
>                 goto out;
>         }
>
> -       *bps = kmalloc(sizeof(struct ras_badpage) * data->count, GFP_KERNEL);
> +       *bps = kmalloc_array(data->count, sizeof(struct ras_badpage), GFP_KERNEL);
>         if (!*bps) {
>                 ret = -ENOMEM;
>                 goto out;
> --
> 2.34.1
>