linux-kernel - Re: [PATCH iproute2-next 1/3] iplink_can: fix coding style for pointer format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fa23787-70a8-47b0-b127-4c6ede546f69@kernel.org>
Date: Tue, 23 Sep 2025 11:07:42 +0900
From: Vincent Mailhol <mailhol@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...il.com>,
 Marc Kleine-Budde <mkl@...gutronix.de>,
 Oliver Hartkopp <socketcan@...tkopp.net>, linux-kernel@...r.kernel.org,
 linux-can@...r.kernel.org
Subject: Re: [PATCH iproute2-next 1/3] iplink_can: fix coding style for
 pointer format

On 23/09/2025 at 07:10, Stephen Hemminger wrote:
> On Sun, 21 Sep 2025 16:32:30 +0900
> Vincent Mailhol <mailhol@...nel.org> wrote:
> 
>> checkpatch.pl complains about the pointer symbol * being attached to the
>> type instead of being attached to the variable:
>>
>>   ERROR: "foo* bar" should be "foo *bar"
>>   #85: FILE: ip/iplink_can.c:85:
>>   +		       const char* name)
>>
>>   ERROR: "foo* bar" should be "foo *bar"
>>   #93: FILE: ip/iplink_can.c:93:
>>   +static void print_ctrlmode(enum output_type t, __u32 flags, const char* key)
>>
>> Fix those two warnings.
>>
>> Signed-off-by: Vincent Mailhol <mailhol@...nel.org>
>> ---
> 
> This is ok, to fix. 

With the other two patches being Nack-ed, we are only left with this one in the
series.

Do you want me to resend or do you prefer to directly cherry pick this one?


Yours sincerely,
Vincent Mailhol