linux-kernel - Re: [PATCH] dt-bindings: rng: sparc_sun_oracle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250923142943.GA3134901-robh@kernel.org>
Date: Tue, 23 Sep 2025 09:29:43 -0500
From: Rob Herring <robh@...nel.org>
To: Kael D'Alcamo <dev@...l-k.io>
Cc: Olivia Mackall <olivia@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-crypto@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: rng: sparc_sun_oracle_rng: convert to DT
 schema

On Tue, Sep 23, 2025 at 12:38:22PM +0200, Kael D'Alcamo wrote:
> Convert the Devicetree binding documentation for:
> * SUNW,n2-rng
> * SUNW,vf-rng
> * SUNW,kt-rng
> * ORCL,m4-rng
> * ORCL,m7-rng
> from plain text to YAML.

While I welcome any conversions, I wouldn't put Sparc stuff high on 
priority list as we're not going to run the validation tools on them 
and we can't change anything in their DTs if we did. My priority is the 
remaining warnings on arm64 and then active arm32 platforms (e.g. 
aspeed). We're down to <700 unique warnings on arm64 (from ~10000). 

There's builds with warnings of Linus' and next trees here:

https://gitlab.com/robherring/linux-dt/-/jobs

And some scripts to fetch the warnings here:

https://gitlab.com/robherring/ci-jobs

> 
> Signed-off-by: Kael D'Alcamo <dev@...l-k.io>
> ---
>  .../bindings/rng/sparc_sun_oracle_rng.txt     | 30 ---------
>  .../bindings/rng/sparc_sun_oracle_rng.yaml    | 61 +++++++++++++++++++

SUNW,n2-rng.yaml for the filename.

>  2 files changed, 61 insertions(+), 30 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.txt
>  create mode 100644 Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.txt b/Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.txt
> deleted file mode 100644
> index b0b211194c71..000000000000
> --- a/Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -HWRNG support for the n2_rng driver
> -
> -Required properties:
> -- reg		: base address to sample from
> -- compatible	: should contain one of the following
> -	RNG versions:
> -	- 'SUNW,n2-rng' for Niagara 2 Platform (SUN UltraSPARC T2 CPU)
> -	- 'SUNW,vf-rng' for Victoria Falls Platform (SUN UltraSPARC T2 Plus CPU)
> -	- 'SUNW,kt-rng' for Rainbow/Yosemite Falls Platform (SUN SPARC T3/T4), (UltraSPARC KT/Niagara 3 - development names)
> -	more recent systems (after Oracle acquisition of SUN)
> -	- 'ORCL,m4-rng' for SPARC T5/M5
> -	- 'ORCL,m7-rng' for SPARC T7/M7
> -
> -Examples:
> -/* linux LDOM on SPARC T5-2 */
> -Node 0xf029a4f4
> -	.node:  f029a4f4
> -	rng-#units:  00000002
> -	compatible: 'ORCL,m4-rng'
> -	reg:  0000000e
> -	name: 'random-number-generator'
> -
> -/* solaris on SPARC M7-8 */
> -Node 0xf028c08c
> -	rng-#units:  00000003
> -	compatible: 'ORCL,m7-rng'
> -	reg:  0000000e
> -	name:  'random-number-generator'
> -
> -PS: see as well prtconfs.git by DaveM
> diff --git a/Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.yaml b/Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.yaml
> new file mode 100644
> index 000000000000..fea6be544784
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/sparc_sun_oracle_rng.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rng/sparc_sun_oracle_rng.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HWRNG support for the n2_rng driver

SUN UltraSPARC HWRNG

> +
> +maintainers:
> +  - David S. Miller <davem@...emloft.net>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - SUNW,n2-rng  # for Niagara 2 Platform (SUN UltraSPARC T2 CPU)
> +      - SUNW,vf-rng  # for Victoria Falls Platform (SUN UltraSPARC T2 Plus CPU)
> +      # for Rainbow/Yosemite Falls Platform (SUN SPARC T3/T4),
> +      #  (UltraSPARC KT/Niagara 3 - development names)
> +      #  more recent systems (after Oracle acquisition of SUN)
> +      - SUNW,kt-rng
> +      - ORCL,m4-rng  # for SPARC T5/M5
> +      - ORCL,m7-rng  # for SPARC T7/M7
> +
> +  reg:
> +    maxItems: 1
> +
> +  "rng-#units":
> +    description: Number of RNG units
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1

This will need an exception in vendor-prefixes.yaml to fix the warning. 
Looking at some of the Sparc DTs briefly, there's a few more ways '#' 
shows up.

I suppose this:

"^[a-zA-Z0-9#_][a-zA-Z0-9+\\-._@]{0,63}$": true

needs to be:

"^[a-zA-Z0-9#_][a-zA-Z0-9#+\\-._@]{0,63}$": true 

(I think the '@' should be dropped here.)

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +# PS: see as well prtconfs.git by DaveM
> +examples:
> +  - |
> +    bus {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        rng@e {
> +            compatible = "ORCL,m4-rng";
> +            reg = <0xe>;
> +            rng-#units = <2>;
> +        };
> +    };
> +  - |
> +    bus {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        rng@e {
> +            compatible = "ORCL,m7-rng";
> +            reg = <0xe>;
> +            rng-#units = <3>;
> +        };
> +    };

I think one example is enough.

Rob