linux-kernel - Re: [PATCH v4] iommu/amd: Add support for hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250923175551.GB2617119@nvidia.com>
Date: Tue, 23 Sep 2025 14:55:51 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Cc: nicolinc@...dia.com, linux-kernel@...r.kernel.org, robin.murphy@....com,
	will@...nel.org, joro@...tes.org, kevin.tian@...el.com,
	jsnitsel@...hat.com, vasant.hegde@....com, iommu@...ts.linux.dev,
	santosh.shukla@....com, sairaj.arunkodilkar@....com,
	jon.grimm@....com, prashanthpra@...gle.com, wvw@...gle.com,
	wnliu@...gle.com, gptran@...gle.com, kpsingh@...gle.com
Subject: Re: [PATCH v4] iommu/amd: Add support for hw_info for iommu
 capability query

On Thu, Sep 04, 2025 at 07:31:12PM +0000, Suravee Suthikulpanit wrote:
> AMD IOMMU Extended Feature (EFR) and Extended Feature 2 (EFR2) registers
> specify features supported by each IOMMU hardware instance.
> The IOMMU driver checks each feature-specific bits before enabling
> each feature at run time.
> 
> For IOMMUFD, the hypervisor passes the raw value of amd_iommu_efr and
> amd_iommu_efr2 to VMM via iommufd IOMMU_DEVICE_GET_HW_INFO ioctl.
> 
> Reviewed-by: Nicolin Chen <nicolinc@...dia.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> ---
> Change in v4:
>  * Add CONFIG_AMD_IOMMU_IOMMUFD
>  * Update comment regarding EFR/EFR2 from struct iommu_hw_info_amd.
> 
> Change in v3:
>  * Remove extern
>  * Fix link to IOMMU spec
>  * Update kdoc
> 
> Change in v2:
>  * Do not mask the EFR/EFR2 and simply return the value reported by hardware
>  * Move amd_iommufd_hw_info() to drivers/iommu/amd/iommufd.c
>  * Also support IOMMU_HW_INFO_TYPE_DEFAULT
> 
>  drivers/iommu/amd/Kconfig    | 10 ++++++++++
>  drivers/iommu/amd/Makefile   |  1 +
>  drivers/iommu/amd/iommu.c    |  2 ++
>  drivers/iommu/amd/iommufd.c  | 31 +++++++++++++++++++++++++++++++
>  drivers/iommu/amd/iommufd.h  | 15 +++++++++++++++
>  include/uapi/linux/iommufd.h | 28 ++++++++++++++++++++++++++++
>  6 files changed, 87 insertions(+)
>  create mode 100644 drivers/iommu/amd/iommufd.c
>  create mode 100644 drivers/iommu/amd/iommufd.h

There was a kbuild issue so this needs to be resent, but

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason