[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250923180305.qmgjilxhujgkvfcp@uda0506412>
Date: Tue, 23 Sep 2025 13:03:05 -0500
From: Kendall Willis <k-willis@...com>
To: Markus Schneider-Pargmann <msp@...libre.com>
CC: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
Tero
Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof
Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Vishal Mahaveer <vishalm@...com>,
Kevin
Hilman <khilman@...libre.com>, Dhruva Gole <d-gole@...com>,
Sebin Francis
<sebin.francis@...com>, Akashdeep Kaur <a-kaur@...com>
Subject: Re: [PATCH v2 2/7] arm64: dts: ti: k3-am62: Define possible system
states
On 11:15-20250812, Markus Schneider-Pargmann wrote:
> Add the system states that are available on am62 SoCs.
>
nit: Change "am62 SoCs" to "TI AM62x SoCs"
Additionally, it would be nice to add what sleep states are supported in
the commit message.
These comments also go for the other two patches that are titled
"Define possible system states".
Best,
Kendall Willis
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62.dtsi b/arch/arm64/boot/dts/ti/k3-am62.dtsi
> index 59f6dff552ed40e4ac0f9c7077aa25d68d3b5283..b08b7062060ca12ecae83917a831ee779f1a288f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62.dtsi
> @@ -46,6 +46,28 @@ pmu: pmu {
> interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + system-idle-states {
> + system_partial_io: system-partial-io {
> + compatible = "system-idle-state";
> + idle-state-name = "off-wake";
> + };
> +
> + system_deep_sleep: system-deep-sleep {
> + compatible = "system-idle-state";
> + idle-state-name = "mem";
> + };
> +
> + system_mcu_only: system-mcu-only {
> + compatible = "system-idle-state";
> + idle-state-name = "mem-mcu-active";
> + };
> +
> + system_standby: system-standby {
> + compatible = "system-idle-state";
> + idle-state-name = "standby";
> + };
> + };
> +
> cbass_main: bus@...00 {
> bootph-all;
> compatible = "simple-bus";
>
> --
> 2.50.1
>
Powered by blists - more mailing lists