linux-kernel - RE: [PATCH v3] media: pci: intel: ivsc: fix error handling in mei

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM8PR11MB56530EE7AB645AA3779AD69B991DA@DM8PR11MB5653.namprd11.prod.outlook.com>
Date: Tue, 23 Sep 2025 03:06:39 +0000
From: "Cao, Bingbu" <bingbu.cao@...el.com>
To: Ma Ke <make24@...as.ac.cn>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "Zhang, Lixu" <lixu.zhang@...el.com>,
	"stanislaw.gruszka@...ux.intel.com" <stanislaw.gruszka@...ux.intel.com>,
	"mchehab@...nel.org" <mchehab@...nel.org>
CC: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: RE: [PATCH v3] media: pci: intel: ivsc: fix error handling in mei_ace
 driver

Hi, Ke

Better update the subject, it's not related to error handling.

------------------------------------------------------------------------
BRs,  
Bingbu Cao

>-----Original Message-----
>From: Ma Ke <make24@...as.ac.cn>
>Sent: Tuesday, September 23, 2025 10:10 AM
>To: sakari.ailus@...ux.intel.com; Cao, Bingbu <bingbu.cao@...el.com>;
>Zhang, Lixu <lixu.zhang@...el.com>; stanislaw.gruszka@...ux.intel.com;
>mchehab@...nel.org
>Cc: linux-media@...r.kernel.org; linux-kernel@...r.kernel.org;
>akpm@...ux-foundation.org; Ma Ke <make24@...as.ac.cn>
>Subject: [PATCH v3] media: pci: intel: ivsc: fix error handling in
>mei_ace driver
>
>The mei_ace driver contains a device reference count leak in
>mei_ace_setup_dev_link() where device_find_child_by_name() increases
>the reference count of the found device but this reference is not
>properly decreased in the success path. Add put_device() in
>mei_ace_setup_dev_link() and delete put_device() in mei_ace_remove(),
>which ensures that the reference count of the device is correctly
>managed regardless of whether the probe is successful or fails.
>
>Found by code review.
>
>Signed-off-by: Ma Ke <make24@...as.ac.cn>
>---
>Changes in v3:
>- deleted the tag of Fixes and CC, and moved put_device() to
>immediately after device_link_add() as suggestions; Changes in v2:
>- modified the put_device() operations and the patch title as
>suggestions.
>---
> drivers/media/pci/intel/ivsc/mei_ace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/media/pci/intel/ivsc/mei_ace.c
>b/drivers/media/pci/intel/ivsc/mei_ace.c
>index 98310b8511b1..9969c02da671 100644
>--- a/drivers/media/pci/intel/ivsc/mei_ace.c
>+++ b/drivers/media/pci/intel/ivsc/mei_ace.c
>@@ -414,6 +414,7 @@ static int mei_ace_setup_dev_link(struct mei_ace
>*ace)
> 	/* setup link between mei_ace and mei_csi */
> 	ace->csi_link = device_link_add(csi_dev, dev, DL_FLAG_PM_RUNTIME
>|
> 					DL_FLAG_RPM_ACTIVE |
>DL_FLAG_STATELESS);
>+	put_device(csi_dev);
> 	if (!ace->csi_link) {
> 		ret = -EINVAL;
> 		dev_err(dev, "failed to link to %s\n", dev_name(csi_dev));
>@@ -522,7 +523,6 @@ static void mei_ace_remove(struct mei_cl_device
>*cldev)
> 	cancel_work_sync(&ace->work);
>
> 	device_link_del(ace->csi_link);
>-	put_device(ace->csi_dev);
>
> 	pm_runtime_disable(&cldev->dev);
> 	pm_runtime_set_suspended(&cldev->dev);
>--
>2.17.1