linux-kernel - Re: [PATCH] kexec_core: Remove superfluous page offset handling in segment loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250922200732.f5c68c706e495635b1536ac2@linux-foundation.org>
Date: Mon, 22 Sep 2025 20:07:32 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Baoquan He <bhe@...hat.com>
Cc: "Bouron, Justinien" <jbouron@...zon.com>, "Rafael J . Wysocki"
 <rafael.j.wysocki@...el.com>, Petr Mladek <pmladek@...e.com>, Mario
 Limonciello <mario.limonciello@....com>, Marcos Paulo de Souza
 <mpdesouza@...e.com>, "Graf (AWS), Alexander" <graf@...zon.de>, Steven Chen
 <chenste@...ux.microsoft.com>, Yan Zhao <yan.y.zhao@...el.com>,
 "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "Kudrjavets, Gunnar" <gunnarku@...zon.com>
Subject: Re: [PATCH] kexec_core: Remove superfluous page offset handling in
 segment loading

On Fri, 12 Sep 2025 14:11:04 +0800 Baoquan He <bhe@...hat.com> wrote:

> > int sanity_check_segment_list(struct kimage *image)
> > {
> >     // ...
> >     for (i = 0; i < nr_segments; i++) {
> >         unsigned long mstart, mend;
> > 
> >         mstart = image->segment[i].mem;
> >         mend   = mstart + image->segment[i].memsz;
> >         if (mstart > mend)
> >             return -EADDRNOTAVAIL;
> >         if ((mstart & ~PAGE_MASK) || (mend & ~PAGE_MASK))
> >             return -EADDRNOTAVAIL;
> >         if (mend >= KEXEC_DESTINATION_MEMORY_LIMIT)
> >             return -EADDRNOTAVAIL;
> >     }
> >     // ...
> > }
> > 
> > > That better be explained in log.
> > Does it warrant a second revision to change the log?
> 
> I would appreciate it if we can tell the reason a little bit in patch
> log. Because we have codes as below where people assign a non PAGE_SIZE
> to kbuf.buf_align. With a general conclusion, people need explore code
> to find out. At least that's what I do when I check this patch.
> 
> arch/x86/kernel/kexec-bzimage64.c:
> static void *bzImage64_load(struct kimage *image, char *kernel,
>                             unsigned long kernel_len, char *initrd,
>                             unsigned long initrd_len, char *cmdline,
>                             unsigned long cmdline_len)
> {

I'll drop this patch.  Justinien, please send along an updated version
for the next -rc cycle, thanks.