linux-kernel - Re: [PATCH v2] gfs2/sysfs: Replace sprintf/snprintf with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250923191900.77568-1-utkarsh.singh.em@gmail.com>
Date: Wed, 24 Sep 2025 00:48:57 +0530
From: Utkarsh Singh <utkarsh.singh.em@...il.com>
To: agruenba@...hat.com
Cc: david.hunter.linux@...il.com,
	gfs2@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	rpeterso@...hat.com,
	skhan@...uxfoundation.org,
	utkarsh.singh.em@...il.com
Subject: Re: [PATCH v2] gfs2/sysfs: Replace sprintf/snprintf with sysfs_emit()

>> Documentation/filesystems/sysfs.rst mentions that show() should only
>> use sysfs_emit() or sysfs_emit_at() when formatting values returned
>> to user space. This patch updates the GFS2 sysfs interface accordingly.
>>
>> It replaces uses of sprintf() and snprintf() in all *_show() functions
>> with sysfs_emit() to align with current kernel sysfs API best practices.
>
>I've applied that part. I'm not pushing this into the upcoming merge
>window anymore, though.
>
Am I correct in understanding that these changes have already been applied?
If so, could you please advise where I might track them to avoid any 
redundant work in the future?
>> It also updates the GFS2_SHOW_UINT macro to use sysfs_emit() instead
>> of snprintf().
>
>Huh, what's that?
>
Sorry for the confusion — that was meant to refer to the `TUNE_ATTR_2`
macro in fs/gfs2/sys.c, which defines the *_show functions for tuning
parameters.

Thanks,
Utkarsh