linux-kernel - Re: [PATCH][next] tls: Avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4b598a1-3ad6-4e42-9f48-21db966f0a34@embeddedor.com>
Date: Tue, 23 Sep 2025 22:53:03 +0200
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] tls: Avoid -Wflex-array-member-not-at-end warning

>>
>> If this (flex array) is not going to be needed in the future, I'm
>> happy to remove it. :)
> 
> I don't see what we'd use it for, aead_request.__ctx contains private
> data from the crypto code (all accesses seem to be through
> aead_request_ctx defined in include/crypto/internal/aead.h, see also
> the kdoc: "Start of private context data").
> And we haven't seen the author of a42055e8d2c3 in a while, so we can't
> ask about the intention behind this field.
> 
> So IMO, tls_rec.aead_req_ctx can simply go away. Would you send the
> patch?
> 

Done: https://lore.kernel.org/linux-hardening/aNMG1lyXw4XEAVaE@kspp/

Thank you for the feedback. :)

-Gustavo