linux-kernel - Re: [PATCH v4 11/14] mm/hugetlbfs: update hugetlbfs to use mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250923141704.90fba5bdf8c790e0496e6ac1@linux-foundation.org>
Date: Tue, 23 Sep 2025 14:17:04 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Sumanth Korikkar <sumanthk@...ux.ibm.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Jonathan Corbet
 <corbet@....net>, Matthew Wilcox <willy@...radead.org>, Guo Ren
 <guoren@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Heiko
 Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander
 Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>,
 "David S . Miller" <davem@...emloft.net>, Andreas Larsson
 <andreas@...sler.com>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Dan Williams <dan.j.williams@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>,
 Nicolas Pitre <nico@...xnic.net>, Muchun Song <muchun.song@...ux.dev>,
 Oscar Salvador <osalvador@...e.de>, David Hildenbrand <david@...hat.com>,
 Konstantin Komarov <almaz.alexandrovich@...agon-software.com>, Baoquan He
 <bhe@...hat.com>, Vivek Goyal <vgoyal@...hat.com>, Dave Young
 <dyoung@...hat.com>, Tony Luck <tony.luck@...el.com>, Reinette Chatre
 <reinette.chatre@...el.com>, Dave Martin <Dave.Martin@....com>, James Morse
 <james.morse@....com>, Alexander Viro <viro@...iv.linux.org.uk>, Christian
 Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, "Liam R . Howlett"
 <Liam.Howlett@...cle.com>, Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport
 <rppt@...nel.org>, Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko
 <mhocko@...e.com>, Hugh Dickins <hughd@...gle.com>, Baolin Wang
 <baolin.wang@...ux.alibaba.com>, Uladzislau Rezki <urezki@...il.com>,
 Dmitry Vyukov <dvyukov@...gle.com>, Andrey Konovalov
 <andreyknvl@...il.com>, Jann Horn <jannh@...gle.com>, Pedro Falcato
 <pfalcato@...e.de>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-csky@...r.kernel.org, linux-mips@...r.kernel.org,
 linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
 nvdimm@...ts.linux.dev, linux-cxl@...r.kernel.org, linux-mm@...ck.org,
 ntfs3@...ts.linux.dev, kexec@...ts.infradead.org,
 kasan-dev@...glegroups.com, Jason Gunthorpe <jgg@...dia.com>,
 iommu@...ts.linux.dev, Kevin Tian <kevin.tian@...el.com>, Will Deacon
 <will@...nel.org>, Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH v4 11/14] mm/hugetlbfs: update hugetlbfs to use
 mmap_prepare

On Tue, 23 Sep 2025 13:52:09 +0200 Sumanth Korikkar <sumanthk@...ux.ibm.com> wrote:

> > --- a/fs/hugetlbfs/inode.c
> > +++ b/fs/hugetlbfs/inode.c
> > @@ -96,8 +96,15 @@ static const struct fs_parameter_spec hugetlb_fs_parameters[] = {
> >  #define PGOFF_LOFFT_MAX \
> >  	(((1UL << (PAGE_SHIFT + 1)) - 1) <<  (BITS_PER_LONG - (PAGE_SHIFT + 1)))
> >  
> > -static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma)
> > +static int hugetlb_file_mmap_prepare_success(const struct vm_area_struct *vma)
> >  {
> > +	/* Unfortunate we have to reassign vma->vm_private_data. */
> > +	return hugetlb_vma_lock_alloc((struct vm_area_struct *)vma);
> > +}
> 
> Hi Lorenzo,
> 
> The following tests causes the kernel to enter a blocked state,
> suggesting an issue related to locking order. I was able to reproduce
> this behavior in certain test runs.

Thanks.  I pulled this series out of mm.git's mm-stable branch, put it
back into mm-unstable.