linux-kernel - Re: [PATCH 4/6] remoteproc: imx_rproc: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250923043348.GB31170@nxa18884-linux.ap.freescale.net>
Date: Tue, 23 Sep 2025 12:33:48 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Mathieu Poirier <mathieu.poirier@...aro.org>
Cc: Peng Fan <peng.fan@....com>, Bjorn Andersson <andersson@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Hiago De Franco <hiago.franco@...adex.com>,
	linux-remoteproc@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] remoteproc: imx_rproc: Use devm_clk_get_enabled()
 and simplify cleanup

On Mon, Sep 22, 2025 at 10:40:58AM -0600, Mathieu Poirier wrote:
>On Wed, Sep 17, 2025 at 09:19:16PM +0800, Peng Fan wrote:
>> Replace separate calls to devm_clk_get() and clk_prepare_enable() with
...
>>  
>> @@ -1187,7 +1178,6 @@ static void imx_rproc_remove(struct platform_device *pdev)
>>  	struct rproc *rproc = platform_get_drvdata(pdev);
>>  	struct imx_rproc *priv = rproc->priv;
>>  
>> -	clk_disable_unprepare(priv->clk);
>
>/home/mpoirier/work/remoteproc/kernel/drivers/remoteproc/imx_rproc.c: In
>function ???imx_rproc_remove???:
>/home/mpoirier/work/remoteproc/kernel/drivers/remoteproc/imx_rproc.c:1179:27:
>warning: unused variable ???priv??? [-Wunused-variable]
> 1179 |         struct imx_rproc *priv = rproc->priv;
>      |                           ^~~~

Oops, this variable is removed in patch 5/6 which should be in this patch.

V2 will have this fixed.

Thanks,
Peng