linux-kernel - Re: [PATCH v2] hwrng: core - Allow runtime disabling of the HW RNG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNIXUADMpZWo0iFz@gondor.apana.org.au>
Date: Tue, 23 Sep 2025 11:43:12 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Jonathan McDowell <noodles@...th.li>
Cc: Olivia Mackall <olivia@...enic.com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org
Subject: Re: [PATCH v2] hwrng: core - Allow runtime disabling of the HW RNG

On Mon, Sep 15, 2025 at 05:02:15PM +0100, Jonathan McDowell wrote:
>
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index 018316f54621..1682a9f1b28c 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -341,6 +341,10 @@ static ssize_t rng_current_store(struct device *dev,
>  	if (sysfs_streq(buf, "")) {
>  		err = enable_best_rng();
> +	} else if (sysfs_streq(buf, "none")) {
> +		if (current_rng)
> +			cur_rng_set_by_user = 1;

Shouldn't this be set unconditionally?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt