linux-kernel - Re: [PATCH v2 08/10] nova-core: falcon: Add support to check if RISC-V is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be96c39c-4ac5-4a4c-b5fc-6b1c1026db30@nvidia.com>
Date: Mon, 22 Sep 2025 18:07:18 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Timur Tabi <ttabi@...dia.com>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 Alistair Popple <apopple@...dia.com>, Alexandre Courbot
 <acourbot@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>
Cc: "lossin@...nel.org" <lossin@...nel.org>,
 "ojeda@...nel.org" <ojeda@...nel.org>,
 "boqun.feng@...il.com" <boqun.feng@...il.com>,
 "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
 "tzimmermann@...e.de" <tzimmermann@...e.de>,
 "tmgross@...ch.edu" <tmgross@...ch.edu>,
 "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
 "simona@...ll.ch" <simona@...ll.ch>, "mripard@...nel.org"
 <mripard@...nel.org>,
 "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
 "airlied@...il.com" <airlied@...il.com>,
 "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
 Joel Fernandes <joelagnelf@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>
Subject: Re: [PATCH v2 08/10] nova-core: falcon: Add support to check if
 RISC-V is active

On 9/22/25 12:12 PM, Timur Tabi wrote:
> On Mon, 2025-09-22 at 21:30 +1000, Alistair Popple wrote:
>> +
>> +    /// Check if the RISC-V core is active.
>> +    ///
>> +    /// Returns `true` if the RISC-V core is active, `false` otherwise.
>> +    #[expect(unused)]
>> +    pub(crate) fn is_riscv_active(&self, bar: &Bar0) -> Result<bool> {
>> +        let cpuctl = regs::NV_PRISCV_RISCV_CPUCTL::read(bar, &E::ID);
>> +        Ok(cpuctl.active_stat())
>> +    }
> 
> This should be part of the HAL, because a different register is used on Turing.
> 
> You can leave it here if you want, and I'll move into a HAL when I post Turing support.  Your
> choice.

Yes, it's similar to the DMA mask patch in that regard (Hopper/Blackwell needs
a different value).

In the spirit of the current "soul" of patchsets, which is "get
GPU firmware running on Ampere/Ada"), I think let's defer the HALs
until the first patchset that needs them.

thanks,
-- 
John Hubbard