linux-kernel - Re: [PATCH 09/14] arm64: dts: qcom: sm6350: add refgen regulator and use it for DSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DCZZV93PMWRZ.1J9IZBZYP5RGM@fairphone.com>
Date: Tue, 23 Sep 2025 09:17:17 +0200
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@....qualcomm.com>, "Liam Girdwood"
 <lgirdwood@...il.com>, "Mark Brown" <broonie@...nel.org>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Konrad Dybcio" <konradybcio@...nel.org>,
 "Bjorn Andersson" <andersson@...nel.org>,
 <cros-qcom-dts-watchers@...omium.org>
Cc: <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <devicetree@...r.kernel.org>
Subject: Re: [PATCH 09/14] arm64: dts: qcom: sm6350: add refgen regulator
 and use it for DSI

Hi Dmitry,

On Sun Sep 21, 2025 at 9:09 AM CEST, Dmitry Baryshkov wrote:
> Add the refgen regulator block and use it for the DSI controller.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm6350.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index 8459b27cacc72a4827a2e289e669163ad6250059..dd009569a6683a25f13b068e3e0bd8746b2ac501 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -1768,6 +1768,12 @@ usb_1_hsphy: phy@...3000 {
>  			resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
>  		};
>  
> +		refgen: regulator@...7000 {
> +			compatible = "qcom,sm6350-refgen-regulator",
> +				     "qcom,sm8250-refgen-regulator";
> +			reg = <0x0 0x088e7000 0x0 0x84>;

Are you sure the size is 0x84? Downstream and hwio_bitra_V1.cmm would
suggest size to be 0x60.

For sc7280, hwio_kodiak_E5.0.cmm does say 0x84 for refgen.

Apart from that, it's also what I have lying around somewhere, should've
upstreamed this already.

Reviewed-by: Luca Weiss <luca.weiss@...rphone.com>

Regards
Luca

> +		};
> +
>  		usb_1_qmpphy: phy@...8000 {
>  			compatible = "qcom,sm6350-qmp-usb3-dp-phy";
>  			reg = <0x0 0x088e8000 0x0 0x3000>;
> @@ -2360,6 +2366,8 @@ mdss_dsi0: dsi@...4000 {
>  				phys = <&mdss_dsi0_phy>;
>  				phy-names = "dsi";
>  
> +				refgen-supply = <&refgen>;
> +
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>