linux-kernel - Re: [PATCH] arch_topology: Fix incorrect error check in topology_parse_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520bab83-191e-4907-8d47-3d9ef8c7c269@web.de>
Date: Tue, 23 Sep 2025 09:46:34 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Kaushlendra Kumar <kaushlendra.kumar@...el.com>,
 kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Danilo Krummrich <dakr@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH] arch_topology: Fix incorrect error check in
 topology_parse_cpu_capacity()

…
> returns NULL. Replace with IS_ERR_OR_NULL() which correctly identifies
> only valid pointers, ensuring clk_get_rate() is called only with valid
> clock objects.

* Can the change description be refined based on documented macro call properties?
  https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/err.h#L101-L123

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

Regards,
Markus