linux-kernel - Re: [PATCH 5.10] gpu/i915: fix error return in mmap_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4u27n4orhmm4fn6xpxbdayqj3fz22lw3il7wjhtif5fjdyitps@d6i6i52giy4j>
Date: Tue, 23 Sep 2025 09:07:10 +0000
From: Krzysztof Karas <krzysztof.karas@...el.com>
To: Alexandr Sapozhnkiov <alsp705@...il.com>
CC: Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>, David Airlie <airlied@...il.com>,
	Daniel Vetter <daniel@...ll.ch>, <intel-gfx@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<linux-media@...r.kernel.org>, <lvc-project@...uxtesting.org>
Subject: Re: [PATCH 5.10] gpu/i915: fix error return in mmap_offset_attach()

Hi Alexandr,

> Return value of function 'drm_vma_node_allow', called 
> at i915_gem_mman.c:670, is not checked, but it is usually 
> checked for this function
Grepping for this function in the repo tells me this is currently
the only place we call it. I'd rephrase the commit message to focus
only on missing return code.

After that:
Reviewed-by: Krzysztof Karas <krzysztof.karas@...el.com>
-- 
Best Regards,
Krzysztof