linux-kernel - Re: [PATCH v2] crypto: caam: Add check for kcalloc() in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509231744.SGr3Dh19-lkp@intel.com>
Date: Tue, 23 Sep 2025 17:20:58 +0800
From: kernel test robot <lkp@...el.com>
To: Guangshuo Li <lgs201920130244@...il.com>,
	Horia Geantă <horia.geanta@....com>,
	Pankaj Gupta <pankaj.gupta@....com>,
	Gaurav Jain <gaurav.jain@....com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	"Victoria Milhoan (b42089)" <vicki.milhoan@...escale.com>,
	Meenakshi Aggarwal <meenakshi.aggarwal@....com>,
	Dan Douglass <dan.douglass@....com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	Guangshuo Li <lgs201920130244@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] crypto: caam: Add check for kcalloc() in test_len()

Hi Guangshuo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v6.17-rc7 next-20250922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Guangshuo-Li/crypto-caam-Add-check-for-kcalloc-in-test_len/20250922-235723
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/20250922155322.1825714-1-lgs201920130244%40gmail.com
patch subject: [PATCH v2] crypto: caam: Add check for kcalloc() in test_len()
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250923/202509231744.SGr3Dh19-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project cafc064fc7a96b3979a023ddae1da2b499d6c954)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250923/202509231744.SGr3Dh19-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509231744.SGr3Dh19-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from <built-in>:3:
   In file included from include/linux/compiler_types.h:171:
   include/linux/compiler-clang.h:28:9: warning: '__SANITIZE_ADDRESS__' macro redefined [-Wmacro-redefined]
      28 | #define __SANITIZE_ADDRESS__
         |         ^
   <built-in>:371:9: note: previous definition is here
     371 | #define __SANITIZE_ADDRESS__ 1
         |         ^
>> drivers/crypto/caam/caamrng.c:186:3: warning: void function 'test_len' should not return a value [-Wreturn-mismatch]
     186 |                 return -ENOMEM;
         |                 ^      ~~~~~~~
   2 warnings generated.


vim +/test_len +186 drivers/crypto/caam/caamrng.c

   174	
   175	#ifdef CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_TEST
   176	static inline void test_len(struct hwrng *rng, size_t len, bool wait)
   177	{
   178		u8 *buf;
   179		int read_len;
   180		struct caam_rng_ctx *ctx = to_caam_rng_ctx(rng);
   181		struct device *dev = ctx->ctrldev;
   182	
   183		buf = kcalloc(CAAM_RNG_MAX_FIFO_STORE_SIZE, sizeof(u8), GFP_KERNEL);
   184	
   185		if (!buf) {
 > 186			return -ENOMEM;
   187		}
   188		while (len > 0) {
   189			read_len = rng->read(rng, buf, len, wait);
   190	
   191			if (read_len < 0 || (read_len == 0 && wait)) {
   192				dev_err(dev, "RNG Read FAILED received %d bytes\n",
   193					read_len);
   194				kfree(buf);
   195				return;
   196			}
   197	
   198			print_hex_dump_debug("random bytes@: ",
   199				DUMP_PREFIX_ADDRESS, 16, 4,
   200				buf, read_len, 1);
   201	
   202			len = len - read_len;
   203		}
   204	
   205		kfree(buf);
   206	}
   207	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki