linux-kernel - Re: [PATCH] drm/gud: fix accidentally deleted IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43972b5a-8bf7-4bfd-be14-45bd47a57d2c@suse.de>
Date: Tue, 23 Sep 2025 13:59:37 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Ruben Wauters <rubenru09@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, lkp@...el.com,
 oe-kbuild@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/gud: fix accidentally deleted IS_ERR() check

Hi

Am 23.09.25 um 11:38 schrieb Ruben Wauters:
> On Tue, 2025-09-23 at 09:57 +0200, Thomas Zimmermann wrote:
>> FYI I got the following warnings. I'll fix them when I merge the
>> patch.
>>
>> -:6: ERROR:GIT_COMMIT_ID: Please use git commit description style
>> 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit
>> 2d2f1dc74cfb
>> ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm versions")'
>> #6:
>> During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit
> I'm not 100% sure why it's complaining about this one, the format
> matches. I assume it's a problem with the line break in it? but I'm not
> 100% sure.
>
>> -:15: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be
>> immediately
>> followed by Closes: with a URL to the report
>> #15:
>> Reported-by: kernel test robot <lkp@...el.com>
>> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> I believe it's intentional to have two reported bys in a row, as both
> of them are followed by a Closes tag at the end.

Neither warning is really your fault. As you say the script doesn't like 
line breaks in certain places. It also only wants pairs of Closes/R-b tags.

Best regards
Thomas

>
> Thanks
>
>> Am 22.09.25 um 19:32 schrieb Ruben Wauters:
>>> During conversion of WARN_ON_ONCE to drm_WARN_ON_ONCE in commit
>>> 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with drm
>>> versions"), the IS_ERR check was accidentally removed, breaking the
>>> gud_connector_add_properties() function, as any valid pointer in
>>> state_val would produce an error.
>>>
>>> The warning was reported by kernel test robot, and is fixed in this
>>> patch.
>>>
>>> Fixes: 2d2f1dc74cfb ("drm: gud: replace WARN_ON/WARN_ON_ONCE with
>>> drm versions")
>>> Reported-by: kernel test robot <lkp@...el.com>
>>> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>>> Closes:
>>> https://lore.kernel.org/r/202509212215.c8v3RKmL-lkp@intel.com/
>>> Signed-off-by: Ruben Wauters <rubenru09@....com>
>>> ---
>>>    drivers/gpu/drm/gud/gud_connector.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/gud/gud_connector.c
>>> b/drivers/gpu/drm/gud/gud_connector.c
>>> index 62e349b06dbe..1726a3fadff8 100644
>>> --- a/drivers/gpu/drm/gud/gud_connector.c
>>> +++ b/drivers/gpu/drm/gud/gud_connector.c
>>> @@ -593,7 +593,7 @@ int gud_connector_fill_properties(struct
>>> drm_connector_state *connector_state,
>>>    			unsigned int *state_val;
>>>    
>>>    			state_val =
>>> gud_connector_tv_state_val(prop, &connector_state->tv);
>>> -			if (drm_WARN_ON_ONCE(connector_state-
>>>> connector->dev, state_val))
>>> +			if (drm_WARN_ON_ONCE(connector_state-
>>>> connector->dev, IS_ERR(state_val)))
>>>    				return PTR_ERR(state_val);
>>>    
>>>    			val = *state_val;

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)