linux-kernel - Re: [PATCH] ocfs2: fix double free in user_cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <okxwk7vmbvfxiypz2uvigrlupr3qbiqenzhih2dehjd3hu4mxd@qtqa6oikikrr>
Date: Tue, 23 Sep 2025 08:52:25 -0400
From: Goldwyn Rodrigues <rgoldwyn@...e.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>, 
	Joseph Qi <joseph.qi@...ux.alibaba.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ocfs2: fix double free in user_cluster_connect()

On 14:26 23/09, Dan Carpenter wrote:
> The user_cluster_disconnect() function frees "conn->cc_private" which is
> "lc" but then the error handling frees "lc" a second time.  Set "lc" to
> NULL on this path to avoid a double free.
> 
> Fixes: c994c2ebdbbc ("ocfs2: use the new DLM operation callbacks while requesting new lockspace")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Looks good. Thanks!

Reviewed-by: Goldwyn Rodrigues <rgoldwyn@...e.de>

-- 
Goldwyn