linux-kernel - Re: [PATCH v2] USB: serial: option: add SIMCom 8230C compositions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B380E8AC5609CE77+6968ccb5-544a-4ddc-8e74-e5b162b4c34f@simcom.com>
Date: Wed, 24 Sep 2025 11:17:58 +0800
From: "xiaowei.li@...com.com" <xiaowei.li@...com.com>
To: Johan Hovold <johan@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] USB: serial: option: add SIMCom 8230C compositions

Hi Johan,

Thanks for the feedback. I have addressed the issues in v2:
- Fixed the From and Signed-off-by mismatch.
- Added an introductory sentence in the commit message.
- Added comments for the new USB device entries.
- Included a changelog below the --- line.

Please find the updated patch attached. Let me know if there are any 
further comments.

Best regards,
Xiaowei Li

在 2025/9/23 15:43, Johan Hovold 写道:
> On Wed, Sep 17, 2025 at 06:53:42PM +0800, xiaowei.li wrote:
> 
> Thanks for the v2.
> 
> Checkpatch complains that your From (author) name does not match you
> SoB (a period '.' instead of space and no capitalisation). Could you fix
> your mailer (or add a From line to the patch) so that the author
> information in the logs will look correct?
> 
> Please consider adding an introductory sentence here (e.g. "Add the
> following compositions for device X:").
> 
>> USB Device Listings:
> 
>> Signed-off-by: Xiaowei Li <xiaowei.li@...com.com>
>> ---
> 
> And when updating patches you should put a short changelog here under
> the --- line.
> 
>>   drivers/usb/serial/option.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index fc869b7f803f..8eadcfe33ecd 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -2114,6 +2114,12 @@ static const struct usb_device_id option_ids[] = {
>>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9003, 0xff) },	/* Simcom SIM7500/SIM7600 MBIM mode */
>>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9011, 0xff),	/* Simcom SIM7500/SIM7600 RNDIS mode */
>>   	  .driver_info = RSVD(7) },
>> +	{ USB_DEVICE(0x1e0e, 0x9071),
>> +	  .driver_info = RSVD(3) | RSVD(4) },
>> +	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9078, 0xff),
>> +	  .driver_info = RSVD(5) },
>> +	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x907b, 0xff),
>> +	  .driver_info = RSVD(5) },
> 
> And please add a comment after these entries with the device and mode
> (like the surrounding entries have).
> 
>>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9205, 0xff) },	/* Simcom SIM7070/SIM7080/SIM7090 AT+ECM mode */
>>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9206, 0xff) },	/* Simcom SIM7070/SIM7080/SIM7090 AT-only mode */
>>   	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_X060S_X200),
> 
> Looks all good otherwise.
> 
> Johan
> 

View attachment "0001-USB-serial-option-add-SIMCom-8230C-compositions.patch" of type "text/plain" (5672 bytes)