linux-kernel - Re: [PATCH] x86/boot: Drop erroneous __init annotation from early_set_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXHGuBB+Z6Yu_u0-NzNH__ho5GqCJH+fDz2ks+WMihVCGA@mail.gmail.com>
Date: Wed, 24 Sep 2025 17:54:21 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Ard Biesheuvel <ardb+git@...gle.com>
Cc: linux-kernel@...r.kernel.org, Borislav Petkov <bp@...en8.de>, 
	"Aithal, Srikanth" <sraithal@....com>, Sean Christopherson <seanjc@...gle.com>, 
	Ashish Kalra <Ashish.Kalra@....com>, Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH] x86/boot: Drop erroneous __init annotation from early_set_pages_state()

On Wed, 24 Sept 2025 at 17:53, Ard Biesheuvel <ardb+git@...gle.com> wrote:
>
> From: Ard Biesheuvel <ardb@...nel.org>
>
> The kexec code will call set_pages_state() after tearing down all the
> GHCBs, which will therefore result in a call to early_set_pages_state().
>
> This means the __init annotation is wrong, and must be dropped.
>
> Fixes: faed658ce71d ("x86/boot: Move startup code out of __head section")
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>

Reported-by: Srikanth Aithal <Srikanth.Aithal@....com>
Tested-by: Srikanth Aithal <Srikanth.Aithal@....com>

> ---
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: "Aithal, Srikanth" <sraithal@....com>
> Cc: Sean Christopherson <seanjc@...gle.com>
> Cc: Ashish Kalra <Ashish.Kalra@....com>
> Cc: Tom Lendacky <thomas.lendacky@....com>
>
>  arch/x86/boot/startup/sev-startup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/startup/sev-startup.c b/arch/x86/boot/startup/sev-startup.c
> index 39465a0ff4e5..c4c389f7cd06 100644
> --- a/arch/x86/boot/startup/sev-startup.c
> +++ b/arch/x86/boot/startup/sev-startup.c
> @@ -44,7 +44,7 @@
>  /* Include code shared with pre-decompression boot stage */
>  #include "sev-shared.c"
>
> -void __init
> +void
>  early_set_pages_state(unsigned long vaddr, unsigned long paddr,
>                       unsigned long npages, const struct psc_desc *desc)
>  {
> --
> 2.51.0.534.gc79095c0ca-goog
>