linux-kernel - Re: [PATCH net-next] dibs: Check correct variable in dibs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d48c84b-c686-4d79-9b56-ede551ad62fc@linux.ibm.com>
Date: Wed, 24 Sep 2025 18:49:53 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
        Julian Ruess <julianr@...ux.ibm.com>
Cc: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] dibs: Check correct variable in dibs_init()



On 24.09.25 16:21, Dan Carpenter wrote:
> There is a typo in this code.  It should check "dibs_class" instead of
> "&dibs_class".  Remove the &.
> 
> Fixes: 804737349813 ("dibs: Create class dibs")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/dibs/dibs_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index 5425238d5a42..0374f8350ff7 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -258,8 +258,8 @@ static int __init dibs_init(void)
>  	max_client = 0;
>  
>  	dibs_class = class_create("dibs");
> -	if (IS_ERR(&dibs_class))
> -		return PTR_ERR(&dibs_class);
> +	if (IS_ERR(dibs_class))
> +		return PTR_ERR(dibs_class);
>  
>  	rc = dibs_loopback_init();
>  	if (rc)

oops, this has been wrong since the first RFC in february.
Great catch, thank you Dan.

Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>