linux-kernel - Re: [PATCH net-next v13 13/18] net: phy: marvell10g: Support SFP through phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff7432c4-27ce-45a1-ac4d-c18d612ef04d@bootlin.com>
Date: Wed, 24 Sep 2025 09:23:55 +0530
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 thomas.petazzoni@...tlin.com, Andrew Lunn <andrew@...n.ch>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Herve Codina <herve.codina@...tlin.com>,
 Florian Fainelli <f.fainelli@...il.com>,
 Heiner Kallweit <hkallweit1@...il.com>,
 Vladimir Oltean <vladimir.oltean@....com>,
 Köry Maincent <kory.maincent@...tlin.com>,
 Marek Behún <kabel@...nel.org>,
 Oleksij Rempel <o.rempel@...gutronix.de>,
 Nicolò Veronese <nicveronese@...il.com>,
 Simon Horman <horms@...nel.org>, mwojtas@...omium.org,
 Antoine Tenart <atenart@...nel.org>, devicetree@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Romain Gantois <romain.gantois@...tlin.com>,
 Daniel Golle <daniel@...rotopia.org>,
 Dimitri Fedrau <dimitri.fedrau@...bherr.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>
Subject: Re: [PATCH net-next v13 13/18] net: phy: marvell10g: Support SFP
 through phy_port



On 24/09/2025 06:54, Jakub Kicinski wrote:
> On Sun, 21 Sep 2025 21:34:11 +0530 Maxime Chevallier wrote:
>> +/**
>> + * phy_port_restrict_mediums - Mask away some of the port's supported mediums
>> + * @port: The port to act upon
>> + * @mediums: A mask of mediums to support on the port
>> + *
>> + * This helper allows removing some mediums from a port's list of supported
>> + * mediums, which occurs once we have enough information about the port to
>> + * know its nature.
>> + *
>> + * Returns 0 if the change was donne correctly, a negative value otherwise.
> 
> kdoc likes colons after return so:
> 
>   Returns 0 -> Return: 0
> 
> sorry for only providing an automated nit pick..

It's OK, the series no longer applies with Russell's sfp_module_caps 
series being here, so a new version is due anyway.

Russell, I missed this series of yours as I wasn't available at all at 
that time, but as this phy_port series has been in the pipe for quite a 
while, and you commented on the used of sfp_parse_support et.al. that 
was being replaced, I'd have appreciated to be in CC :(

Given my schedule, next iteration is probably going to be for the next 
cycle anyway so no harm :)

Thanks,

Maxime

> 
>> + */
>> +int phy_port_restrict_mediums(struct phy_port *port, unsigned long mediums)