linux-kernel - Re: [PATCH net-next 1/7] net/mlx5: HWS, Generalize complex matchers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNQzb1VPhkAdEdd7@nvidia.com>
Date: Wed, 24 Sep 2025 20:07:43 +0200
From: Vlad Dogaru <vdogaru@...dia.com>
To: Simon Horman <horms@...nel.org>
Cc: Tariq Toukan <tariqt@...dia.com>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Saeed Mahameed <saeedm@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, Mark Bloch <mbloch@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, Gal Pressman <gal@...dia.com>,
	Moshe Shemesh <moshe@...dia.com>,
	Yevgeny Kliteynik <kliteyn@...dia.com>
Subject: Re: [PATCH net-next 1/7] net/mlx5: HWS, Generalize complex matchers

On Wed, Sep 24, 2025 at 05:17:27PM +0100, Simon Horman wrote:
> On Mon, Sep 22, 2025 at 12:01:05PM +0300, Tariq Toukan wrote:
> > From: Vlad Dogaru <vdogaru@...dia.com>
> 
> ...
> 
> > +static int hws_complex_subrule_create(struct mlx5hws_bwc_matcher *cmatcher,
> > +				      struct mlx5hws_bwc_rule *subrule,
> > +				      u32 *match_params, u32 flow_source,
> > +				      int bwc_queue_idx, int subm_idx,
> > +				      struct mlx5hws_rule_action *actions,
> > +				      u32 *chain_id)
> >  {
> 
> ...
> 
> > +	ret = mlx5hws_bwc_rule_create_simple(subrule, match_params, actions,
> > +					     flow_source, bwc_queue_idx);
> > +	if (ret) {
> > +		goto put_subrule_data;
> > +		goto unlock;
> 
> Hi Tariq and Vlad,
> 
> I guess it's a simple editing artifact.
> But it seems that the line above is dead code.
> 
> Flagged by Smatch.

Hi Simon,

Thanks for the heads up, will fix in v2.

Cheers,
Vlad