linux-kernel - Re: [PATCH 12/15] scsi: qla2xxx: add cmd->rsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c95de97f-2cf4-429c-b4d4-86f285f3c43e@cybernetics.com>
Date: Wed, 24 Sep 2025 16:04:58 -0400
From: Tony Battersby <tonyb@...ernetics.com>
To: Dmitry Bogdanov <d.bogdanov@...ro.com>
Cc: Nilesh Javali <njavali@...vell.com>,
 GR-QLogic-Storage-Upstream@...vell.com,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 linux-scsi <linux-scsi@...r.kernel.org>, target-devel@...r.kernel.org,
 scst-devel@...ts.sourceforge.net,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 12/15] scsi: qla2xxx: add cmd->rsp_sent

On 9/15/25 09:47, Dmitry Bogdanov wrote:
> On Mon, Sep 08, 2025 at 03:07:04PM -0400, Tony Battersby wrote:
>> (target mode)
>>
>> Add cmd->rsp_sent to indicate that the SCSI status has been sent
>> successfully, so that SCST can be informed of any transport errors.
>> This will also be used for logging in later patches.
>>
>> Signed-off-by: Tony Battersby <tonyb@...ernetics.com>
>> ---
>>  drivers/scsi/qla2xxx/qla_target.c | 4 ++++
>>  drivers/scsi/qla2xxx/qla_target.h | 4 ++++
>>  2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
>> index eabb891a5528..0ddbf02ebe79 100644
>> --- a/drivers/scsi/qla2xxx/qla_target.c
>> +++ b/drivers/scsi/qla2xxx/qla_target.c
>> @@ -4067,6 +4067,10 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha,
>>
>>         if (cmd->state == QLA_TGT_STATE_PROCESSED) {
>>                 cmd->trc_flags |= TRC_CTIO_DONE;
>> +
>> +               if (likely(status == CTIO_SUCCESS))
>> +                       cmd->rsp_sent = 1;
> Looks like TRC_CTIO_DONE without TRC_DIF_ERR and TRC_CTIO_ERR means
> exactly that CTIO was completed successfully.

That may be true, but I still prefer to add the separate rsp_sent
field.  trc_flags is a debug feature, and I expect that relying on
specific meanings of debug flags in non-debug code would make the code
more fragile.

Tony