linux-kernel - Re: [PATCH] crypto: af_alg - Fix incorrect boolean values in af_alg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wjk5rMWnVt6K_3BSQ=_uEKNaYBs=FZH_fMLKqp9E4G8kg@mail.gmail.com>
Date: Wed, 24 Sep 2025 13:17:10 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, Herbert Xu <herbert@...dor.apana.org.au>, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] crypto: af_alg - Fix incorrect boolean values in af_alg_ctx

On Wed, 24 Sept 2025 at 13:13, Eric Biggers <ebiggers@...nel.org> wrote:
>
> I do think the idea of trying to re-pack the structure as part of a bug
> fix is a bit misguided, though.

Well, now it's done, so let's not change it even *more*, when a
one-liner should fix it.

I do agree that clearly the original fix was clearly buggy, but unless
it's reverted entirely I'd rather go for "minimal one-liner fix on top
of buggy fix", particularly since the end result is then better...

             Linus