linux-kernel - Re: [PATCH v2][next] tls: Avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNRSACsf_h3ePDhf@krikkit>
Date: Wed, 24 Sep 2025 22:18:08 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: John Fastabend <john.fastabend@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2][next] tls: Avoid -Wflex-array-member-not-at-end
 warning

Thanks for the updated patch.

A process nit: the correct subject prefix for this type of work within
networking would be [PATCH net-next v2] (indicating it targets the
"net-next" tree).

2025-09-23, 22:45:10 +0200, Gustavo A. R. Silva wrote:
> Remove unused flexible-array member in struct tls_rec and, with this,
> fix the following warning:
> 
> net/tls/tls.h:131:29: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Also, add a comment to prevent people from adding any members
> after struct aead_request, which is a flexible structure --this is
> a structure that ends in a flexible-array member.

Once that warning is enabled, re-adding a field after aead_req will
not be allowed by the compiler, right?  The comment is probably not
really needed, but since there are "must be first" comments all over
include/net, I guess it's useful.

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina