linux-kernel - Re: [PATCH V3 03/20] nvdimm/label: Modify nd_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNRccteuoHH0oPw4@aschofie-mobl2.lan>
Date: Wed, 24 Sep 2025 14:02:42 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: Neeraj Kumar <s.neeraj@...sung.com>
CC: Dave Jiang <dave.jiang@...el.com>, <linux-cxl@...r.kernel.org>,
	<nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
	<gost.dev@...sung.com>, <a.manzanares@...sung.com>, <vishak.g@...sung.com>,
	<neeraj.kernel@...il.com>, <cpgs@...sung.com>
Subject: Re: [PATCH V3 03/20] nvdimm/label: Modify nd_label_base() signature

On Mon, Sep 22, 2025 at 06:14:40PM +0530, Neeraj Kumar wrote:
> On 19/09/25 04:34PM, Dave Jiang wrote:
> > 
> > 
> > On 9/17/25 6:40 AM, Neeraj Kumar wrote:
> > > nd_label_base() was being used after typecasting with 'unsigned long'. Thus
> > > modified nd_label_base() to return 'unsigned long' instead of 'struct
> > > nd_namespace_label *'
> > > 
> > > Signed-off-by: Neeraj Kumar <s.neeraj@...sung.com>
> > Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> > 
> > Just a nit below:
> > 
> > 
> > > ---
> > >  drivers/nvdimm/label.c | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > -static struct nd_namespace_label *nd_label_base(struct nvdimm_drvdata *ndd)
> > > +static unsigned long nd_label_base(struct nvdimm_drvdata *ndd)
> > >  {
> > >  	void *base = to_namespace_index(ndd, 0);
> > > 
> > > -	return base + 2 * sizeof_namespace_index(ndd);
> > > +	return (unsigned long) (base + 2 * sizeof_namespace_index(ndd));
> > 
> > Space is not needed between casting and the var. Also applies to other instances in this commit.
> > 
> > DJ
> 
> Thanks Jonathan, Ira and Dave for RB tag. Sure, I will fix this in next
> patch-set.

This is independent of the patchset, right?
How about just sending a one off patch for this, and shortening this
set by a tiny bit :)


> 
> 
> Regards,
> Neeraj