linux-kernel - Re: [PATCH mm-new 1/1] mm: clean up is_guard_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a4f1846-06fd-414e-ae5f-43d3d5270380@arm.com>
Date: Wed, 24 Sep 2025 10:49:24 +0530
From: Dev Jain <dev.jain@....com>
To: Lance Yang <lance.yang@...ux.dev>, akpm@...ux-foundation.org
Cc: richard.weiyang@...il.com, Liam.Howlett@...cle.com, baohua@...nel.org,
 baolin.wang@...ux.alibaba.com, david@...hat.com, hughd@...gle.com,
 ioworker0@...il.com, kasong@...cent.com, kirill@...temov.name,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 lorenzo.stoakes@...cle.com, mpenttil@...hat.com, npache@...hat.com,
 ryan.roberts@....com, ziy@...dia.com
Subject: Re: [PATCH mm-new 1/1] mm: clean up is_guard_pte_marker()


On 24/09/25 10:28 am, Lance Yang wrote:
> From: Lance Yang <lance.yang@...ux.dev>
>
> Let's simplify the implementation. The current code is redundant as it
> effectively expands to:
>
>    is_swap_pte(pte) &&
>    is_pte_marker_entry(...) && // from is_pte_marker()
>    is_pte_marker_entry(...)    // from is_guard_swp_entry()
>
> While a modern compiler could likely optimize this away, let's have clean
> code and not rely on it.
>
> Reviewed-by: Wei Yang <richard.weiyang@...il.com>
> Reviewed-by: Zi Yan <ziy@...dia.com>
> Acked-by: David Hildenbrand <david@...hat.com>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> Signed-off-by: Lance Yang <lance.yang@...ux.dev>
> ---

Reviewed-by: Dev Jain <dev.jain@....com>