linux-kernel - Re: [PATCH net-next v2 5/6] netconsole: resume previously deactivated target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dafma6drqvct4wlzcujoysnvjnk6c4ptib4tdtuqt73fcuc5op@efjjn5ajqwts>
Date: Wed, 24 Sep 2025 23:26:58 +0100
From: Andre Carvalho <asantostc@...il.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, 
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/6] netconsole: resume previously
 deactivated target

Hi Breno,

On Wed, Sep 24, 2025 at 01:26:16AM -0700, Breno Leitao wrote:
> The other option is to always populate the mac during netpoll setup and
> then always resume based on mac. This seems a more precise resume.
>
> In this case, if the device goes to DEACTIVATED, then np.dev_mac will be
> populated, and you only compare it to check if you want to resume it.

This sounds good to me. I've done some initial testing patching __netpoll_setup
to always set np->dev_mac, changing maybe_resume_target to simply compare the
mac as you suggested and seems like this approach works. 

I'll do more testing and analysis to see if I see any issue with the approach. 
If all goes well, I can include these changes in v3. I'll report back in case I
find any problems.