linux-kernel - RE: [PATCH rtw-next] wifi: rtw89: Replace hardcoded strings with helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51518b935e7649e3b5413e3a119d549b@realtek.com>
Date: Wed, 24 Sep 2025 00:43:56 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Yu-Chun Lin <eleanor15x@...il.com>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        CY_Huang[黃鉦晏] <cy.huang@...ltek.com>,
        Stanley Chang[昌育德] <stanley_chang@...ltek.com>,
        "jserv@...s.ncku.edu.tw" <jserv@...s.ncku.edu.tw>,
        "visitorckw@...il.com"
	<visitorckw@...il.com>
Subject: RE: [PATCH rtw-next] wifi: rtw89: Replace hardcoded strings with helper functions

Yu-Chun Lin <eleanor15x@...il.com> wrote:
> On Mon, Sep 22, 2025 at 05:50:50AM +0000, Ping-Ke Shih wrote:
> > Yu-Chun Lin <eleanor15x@...il.com> wrote:
> > > Replace hardcoded strings with 'str_on_off()', 'str_enable_disable()',
> > > and 'str_read_write()'.
> > >
> > > The change improves readability and enables potential string deduplication
> > > by the linker, which may slightly reduce binary size.
> >
> > Have you measured the change of binary size? Maybe you can share the result
> > here.
> >
> 
> I tested the patch and did not observe any measurable change in the binary size.
> The commit message was refers to the description in string-choice.h:
> 
> "3) Deduping by the linker, which results in a smaller binary file."

It might rely on LTO (link-time optimization).