linux-kernel - Re: [PATCH] ASoC: stm32: sai: manage context in set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tt0rzb3b.wl-kuninori.morimoto.gx@renesas.com>
Date: Wed, 24 Sep 2025 23:26:16 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Olivier MOYSAN <olivier.moysan@...s.st.com>
Cc: Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>,
	Liam Girdwood
	<lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela
	<perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Maxime Coquelin
	<mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	<linux-sound@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: stm32: sai: manage context in set_sysclk callback


Hi Olivier

> > Or maybe reset simple_dai->sysclk somehow (not sure...) ?
> > (simple_init_dai() will call snd_soc_dai_set_sysclk() if it has
> > simple_dai->sysclk)
> > 
> 
> Yes, resetting simple_dai->sysclk may also be an option, but I could not 
> find a way to do it in practice. Requesting a reset of 
> simple_dai->sysclk from the CPU DAI .probe callback might be the right 
> time I think, but there is no service that allows this.
> Another way would be to set "system-clock-frequency = <0>" in the CPU DT 
> node. However, this is not possible, as it conflicts with the following 
> check in the simple_set_clk_rate() function:
> if (simple_dai->clk_fixed && rate != simple_dai->sysclk) {
>     dev_err(...)
> }

OK, thank you for confirming the situation.

Generalize closk setting is one of complex code, and some driver might get
damage if framework was updated, like you.

> So, the current patch still seems like the better option to me.

Yeah, it seems.


Thank you for your help !!

Best regards
---
Kuninori Morimoto