linux-kernel - Re: [PATCH] Fix the cleanup on alloc_mpc failure in atm_mpoa_mpoad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250924164501.23f6e708@kernel.org>
Date: Wed, 24 Sep 2025 16:45:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: Deepak Sharma <deepak.sharma.472935@...il.com>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, pwn9uin@...il.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 syzbot+07b635b9c111c566af8b@...kaller.appspotmail.com
Subject: Re: [PATCH] Fix the cleanup on alloc_mpc failure in
 atm_mpoa_mpoad_attach

On Wed, 24 Sep 2025 19:44:51 +0100 Simon Horman wrote:
> The preferred coding style is:
> 
> 		if (mpc == NULL) {

Or better still:

		if (!mpc)

we tend to avoid comparisons to zero and NULL.