linux-kernel - Re: [PATCH for-6.18/block 1/2] blk-cgroup: allocate policy data with GFP_NOIO in blkcg_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ae65be1-65b2-208c-ad25-68905c4f2331@huaweicloud.com>
Date: Wed, 24 Sep 2025 08:52:16 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Ming Lei <ming.lei@...hat.com>, Yu Kuai <yukuai1@...weicloud.com>
Cc: nilay@...ux.ibm.com, tj@...nel.org, josef@...icpanda.com,
 axboe@...nel.dk, cgroups@...r.kernel.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 johnny.chenyi@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH for-6.18/block 1/2] blk-cgroup: allocate policy data with
 GFP_NOIO in blkcg_activate_policy()

Hi,

在 2025/09/23 19:03, Ming Lei 写道:
> On Tue, Sep 23, 2025 at 4:06 PM Yu Kuai <yukuai1@...weicloud.com> wrote:
>>
>> From: Yu Kuai <yukuai3@...wei.com>
>>
>> Queue is freezed while activating policy, allocate memory with queue
>> freezed has the risk of deadlock because memory reclaim can issue new
>> IO.
> 
> blk_mq_freeze_queue() already covers it by calling memalloc_noio_save(),
> so this patch looks not necessary.
> 
Yes, this can just consider a cleanup, I'll remove this if we think this
is not necessary.

> Or do you have a lockdep warning?
> 

No.

Thanks,
Kuai

> Thanks,
> 
> 
> 
> .
>