linux-kernel - Re: [PATCH] mtd: rawnand: omap2: fix device leak on probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zfakpa7f.fsf@bootlin.com>
Date: Wed, 24 Sep 2025 09:43:16 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Johan Hovold <johan@...nel.org>,  linux-mtd@...ts.infradead.org,  LKML
 <linux-kernel@...r.kernel.org>,  Richard Weinberger <richard@....at>,
  Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH] mtd: rawnand: omap2: fix device leak on probe failure

Hi Markus,

>> @@ -2083,10 +2084,24 @@ static int omap_nand_attach_chip(struct nand_chip *chip)
>>  		dev_err(dev,
>>  			"Not enough OOB bytes: required = %d, available=%d\n",
>>  			min_oobbytes, mtd->oobsize);
>> -		return -EINVAL;
>> +		err = -EINVAL;
>> +		goto err_put_elm_dev;
>>  	}
> …
>
> May such an error code assignment be moved behind an additional label?

I don't think that's how labels are supposed to be used, current
proposal looks correct IMO.

Thanks,
Miquèl