linux-kernel - Re: [PATCH net-next v13 1/5] net: rnpgbe: Add build support for rnpgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250923180854.46adc958@kernel.org>
Date: Tue, 23 Sep 2025 18:08:54 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dong Yibo <dong100@...se.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, corbet@....net, gur.stavi@...wei.com,
 maddy@...ux.ibm.com, mpe@...erman.id.au, danishanwar@...com, lee@...ger.us,
 gongfan1@...wei.com, lorenzo@...nel.org, geert+renesas@...der.be,
 Parthiban.Veerasooran@...rochip.com, lukas.bulwahn@...hat.com,
 alexanderduyck@...com, richardcochran@...il.com, kees@...nel.org,
 gustavoars@...nel.org, rdunlap@...radead.org, vadim.fedorenko@...ux.dev,
 joerg@...so.de, netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Andrew Lunn
 <andrew@...n.ch>
Subject: Re: [PATCH net-next v13 1/5] net: rnpgbe: Add build support for
 rnpgbe

On Mon, 22 Sep 2025 09:41:07 +0800 Dong Yibo wrote:
> +===========================================================
> +Linux Base Driver for MUCSE(R) Gigabit PCI Express Adapters
> +===========================================================
> +
> +MUCSE Gigabit Linux driver.

You already said that in the heading above

> +Copyright (c) 2020 - 2025 MUCSE Co.,Ltd.

copyright is metadata, it should not be part of the user-visible doc.

> +Identifying Your Adapter
> +========================
> +The driver is compatible with devices based on the following:
> +
> + * MUCSE(R) Ethernet Controller N500 series
> + * MUCSE(R) Ethernet Controller N210 series

These are out of numeric sort order

> +Support
> +=======
> + If you have problems with the software or hardware, please contact our
> + customer support team via email at techsupport@...se.com or check our
> + website at https://www.mucse.com/en/

Please don't add support statements. People can use a search engine if
they want to find the corporate support. The kernel docs are for kernel
topics, and "support" in the kernel is done on the mailing list.


> +config MGBE
> +	tristate "Mucse(R) 1GbE PCI Express adapters support"
> +	depends on PCI
> +	select PAGE_POOL

you're not using page pool in this series

> +MODULE_DEVICE_TABLE(pci, rnpgbe_pci_tbl);
> +MODULE_AUTHOR("Mucse Corporation, <techsupport@...se.com>");

Only humans can author code, not corporations. Delete his AUTHOR entry
or add yourself as the author.

> +MODULE_DESCRIPTION("Mucse(R) 1 Gigabit PCI Express Network Driver");
> +MODULE_LICENSE("GPL");