linux-kernel - Re: [PATCH v2] tee: fix register_shm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHUa44FtbqOnbBvOSNkX+jdqUK-+hTAM3hYseMPbhOt0U_Nxqw@mail.gmail.com>
Date: Wed, 24 Sep 2025 10:28:03 +0200
From: Jens Wiklander <jens.wiklander@...aro.org>
To: Sumit Garg <sumit.garg@...nel.org>
Cc: linux-kernel@...r.kernel.org, op-tee@...ts.trustedfirmware.org, 
	Jerome Forissier <jerome.forissier@...aro.org>, stable@...r.kernel.org, 
	Masami Ichikawa <masami256@...il.com>
Subject: Re: [PATCH v2] tee: fix register_shm_helper()

On Mon, Sep 22, 2025 at 10:50 AM Sumit Garg <sumit.garg@...nel.org> wrote:
>
> On Mon, Sep 22, 2025 at 10:31:58AM +0200, Jens Wiklander wrote:
> > In register_shm_helper(), fix incorrect error handling for a call to
> > iov_iter_extract_pages(). A case is missing for when
> > iov_iter_extract_pages() only got some pages and return a number larger
> > than 0, but not the requested amount.
> >
> > This fixes a possible NULL pointer dereference following a bad input from
> > ioctl(TEE_IOC_SHM_REGISTER) where parts of the buffer isn't mapped.
> >
> > Cc: stable@...r.kernel.org
> > Reported-by: Masami Ichikawa <masami256@...il.com>
> > Closes: https://lore.kernel.org/op-tee/CACOXgS-Bo2W72Nj1_44c7bntyNYOavnTjJAvUbEiQfq=u9W+-g@mail.gmail.com/
> > Tested-by: Masami Ichikawa <masami256@...il.com>
> > Fixes: 7bdee4157591 ("tee: Use iov_iter to better support shared buffer registration")
> > Signed-off-by: Jens Wiklander <jens.wiklander@...aro.org>
> > ---
> > Changes from v1
> > - Refactor the if statement as requested by Sumit
> > - Adding Tested-by: Masami Ichikawa <masami256@...il.com
> > - Link to v1:
> >   https://lore.kernel.org/op-tee/20250919124217.2934718-1-jens.wiklander@linaro.org/
> > ---
> >  drivers/tee/tee_shm.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
>
> Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>

I'm picking up this.

Thanks,
Jens