linux-kernel - Re: [PATCH v2 1/2] dt-bindings: PCI: mediatek-gen3: Add support for Airoha AN7583

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18af5a93-e5b1-45fa-b942-47c6c3cd5ddb@collabora.com>
Date: Wed, 24 Sep 2025 10:40:31 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Christian Marangi <ansuelsmth@...il.com>,
 Ryder Lee <ryder.lee@...iatek.com>, Jianjun Wang
 <jianjun.wang@...iatek.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 linux-pci@...r.kernel.org, linux-mediatek@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, upstream@...oha.com
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: mediatek-gen3: Add support for
 Airoha AN7583

Il 24/09/25 10:36, AngeloGioacchino Del Regno ha scritto:
> Il 23/09/25 21:06, Christian Marangi ha scritto:
>> Introduce Airoha AN7583 SoC compatible in mediatek-gen3 PCIe controller
>> binding.
>>
>> This differ from the Airoha EN7581 SoC by the fact that only one Gen3
>> PCIe controller is present on the SoC.
>>
>> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
>> ---
>> Changes v2:
>> - Fix alphabetical order
>>
>>   .../bindings/pci/mediatek-pcie-gen3.yaml      | 21 +++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/ 
>> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
>> index 0278845701ce..1ca9594a9739 100644
>> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
>> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
>> @@ -58,6 +58,7 @@ properties:
>>             - const: mediatek,mt8196-pcie
>>         - const: mediatek,mt8192-pcie
>>         - const: mediatek,mt8196-pcie
>> +      - const: airoha,an7583-pcie-gen3
> 
> In the previous review, I also asked you to change the compatible string to be
> consistent with the others.
> 
> airoha,an7583-pcie

I have just seen the other series where you add AN7583 to the GEN2 PCIe controller
driver; this means that this SoC has two controllers, one GEN2 and one GEN3.

The compatible string inconsistency is therefore acceptable.

Please, though - add this information in the commit message, saying that the new
string is inconsistent with the others and explain the reason.

After which,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>